393662 - Removal of Old GFX and obsolete codes in nsBaseWidget.cpp

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Jonathan Steele]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082405 Minefield/3.0a8pre
Build Identifier: 

The non-Cairo code in gtk2bin.h is outdated and should be removed. 

nsIWidget *parent = GetParent();
if (!parent)
   return nsnull;
  
   // in theory we should get our parent's surface,
   // clone it, and set a device offset before returning
return nsnull;

By looking of this code, if parent variable is true and false, it return nsnull;This parent variable isn't needed at all?
O


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jonathan Steele]

Oops, it should be nsBaseWidget.cpp instead gtk2bin.h. Just ignore last O.

Comment 2

[Jonathan Steele]

Attachment: Removing Cairo and useless parent checks

Comment 3

[Nickolay_Ponomarev]

mozilla/widget/src/xpwidgets/nsBaseWidget.cpp  1.161