Closed Bug 393665 Opened 13 years ago Closed 13 years ago

Crash [@ nsRect::nsRect] with <xul:treechildren style="display: block">

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: neil)

References

(Blocks 2 open bugs)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(2 files)

No description provided.
Oops. My bad.
Assignee: Jan.Varga → neil
Blocks: 306990
Attached patch Proposed patchSplinter Review
Oops, I forgot to null-check mColumnsFrame.

This seemed to be the simplest set of changes to fix the bug. It works because mColumnsFrame is never null if width is non-zero. The case that this doesn't consider is that mColumnsFrame is a scrollable frame with no scrollable view.
Attachment #278204 - Flags: superreview?(roc)
Attachment #278204 - Flags: review?(enndeakin)
Attachment #278204 - Flags: review?(enndeakin) → review+
Attachment #278204 - Flags: superreview?(roc)
Attachment #278204 - Flags: superreview+
Attachment #278204 - Flags: approval1.9+
Fix checked in.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Crashtest checked in.
Flags: in-testsuite+
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
Crash Signature: [@ nsRect::nsRect]
You need to log in before you can comment on or make changes to this bug.