393671 - [FIX]"ASSERTION: expected the float to be a child of the outer CB" and more with float, block-in-inline

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers a pair of assertions:

###!!! ASSERTION: expected the float to be a child of the outer CB: 'outOfFlowFrame->GetParent() == aOuterState.mFloatedItems.containingBlock', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1587

###!!! ASSERTION: float wasn't in the outer state float list: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1592

Applying the patches in bug 393649 and bug 393517 doesn't make these assertions go away.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

This goes on top of those two patches.  The problem here is that we need to move the floats to the "final" reflow state, and without this patch we're not doing it.

The reftests fail without this patch: the text in the float doesn't show up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fixed.