[FIX]"ASSERTION: expected the float to be a child of the outer CB" and more with float, block-in-inline

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Core
Layout
P1
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 2 bugs, {assertion, testcase})

Trunk
mozilla1.9alpha8
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Created attachment 278194 [details]
testcase

Loading the testcase triggers a pair of assertions:

###!!! ASSERTION: expected the float to be a child of the outer CB: 'outOfFlowFrame->GetParent() == aOuterState.mFloatedItems.containingBlock', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1587

###!!! ASSERTION: float wasn't in the outer state float list: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1592

Applying the patches in bug 393649 and bug 393517 doesn't make these assertions go away.
Created attachment 278255 [details] [diff] [review]
Fix

This goes on top of those two patches.  The problem here is that we need to move the floats to the "final" reflow state, and without this patch we're not doing it.

The reftests fail without this patch: the text in the float doesn't show up.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #278255 - Flags: superreview?(roc)
Attachment #278255 - Flags: review?(roc)
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Summary: "ASSERTION: expected the float to be a child of the outer CB" and more with float, block-in-inline → [FIX]"ASSERTION: expected the float to be a child of the outer CB" and more with float, block-in-inline
Target Milestone: --- → mozilla1.9 M8
Attachment #278255 - Flags: superreview?(roc)
Attachment #278255 - Flags: superreview+
Attachment #278255 - Flags: review?(roc)
Attachment #278255 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.