Closed
Bug 393707
Opened 17 years ago
Closed 16 years ago
Landing 389634 broke building without XUL
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
|
11.50 KB,
patch
|
smaug
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/Makefile.in#76 Disable building nsPromptService.cpp, but there are defined nsAutoWindowStateHelper http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsPromptService.h#84 Result building of http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsWindowWatcher.cpp#930 Broken.
Attachment #278235 -
Flags: review?(bzbarsky)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 278235 [details] [diff] [review] Fast fix with This is the wrong fix. The right fix is for this not to be MOZ_XUL. See also bug 391100 comment 8.
Attachment #278235 -
Flags: review?(bzbarsky) → review-
|
Assignee | |
Comment 2•17 years ago
|
||
Hmmm... I would glad to see that bug, but there are Access Denied
|
||
Comment 3•17 years ago
|
||
I didn't realize that promptservice was only built ifdef MOZ_XUL. You could just move nsAutoWindowStateHelper to its own file to fix this bug.
|
|
Assignee | |
Comment 4•17 years ago
|
||
May be it would be better move it inside nsPrompt.h|cpp files?
|
|
||
Comment 5•17 years ago
|
||
That's where it used to be, it got moved out to fix bug 389634
|
||
Comment 6•17 years ago
|
||
So, was nsWindowWatcher.cpp the wrong place to move it to, or was there a problem with how it was moved?
|
|
||
Comment 7•17 years ago
|
||
it was moved to nsPromptService.cpp, not to nsWindowWatcher.cpp. And yeah, it looks like that was not a good place to move it to. see comment 3.
|
|
Assignee | |
Comment 8•17 years ago
|
||
Assignee: nobody → romaxa
Attachment #278235 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #297552 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #297552 -
Flags: review? → review?(bzbarsky)
|
|
||
Comment 9•16 years ago
|
||
I won't get to this until June. Please ask someone else for review.
|
|
Assignee | |
Comment 10•16 years ago
|
||
Comment on attachment 297552 [details] [diff] [review] Fixed according to comment #3 Olli, could you check this patch?
Attachment #297552 -
Flags: review?(bzbarsky) → review?(Olli.Pettay)
|
||
Comment 11•16 years ago
|
||
Comment on attachment 297552 [details] [diff] [review] Fixed according to comment #3 This just moves code to a better place. r=me
Attachment #297552 -
Flags: review?(Olli.Pettay) → review+
|
||
Comment 12•16 years ago
|
||
Comment on attachment 297552 [details] [diff] [review] Fixed according to comment #3 Moves XUL-only code to its own file.
Attachment #297552 -
Flags: approval1.9?
|
||
Comment 13•16 years ago
|
||
Comment on attachment 297552 [details] [diff] [review] Fixed according to comment #3 a1.9=beltzner
Attachment #297552 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 14•16 years ago
|
||
mozilla/embedding/components/windowwatcher/src/Makefile.in 1.29 mozilla/embedding/components/windowwatcher/src/nsAutoWindowStateHelper.cpp 1.1 mozilla/embedding/components/windowwatcher/src/nsAutoWindowStateHelper.h 1.1 mozilla/embedding/components/windowwatcher/src/nsPromptService.cpp 1.39 mozilla/embedding/components/windowwatcher/src/nsPromptService.h 1.15
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•