If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Landing 389634 broke building without XUL

RESOLVED FIXED in mozilla1.9

Status

()

Core
DOM
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 278235 [details] [diff] [review]
Fast fix with 

http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/Makefile.in#76

Disable building nsPromptService.cpp, but there are defined 
nsAutoWindowStateHelper
http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsPromptService.h#84

Result building of 
http://mxr.mozilla.org/seamonkey/source/embedding/components/windowwatcher/src/nsWindowWatcher.cpp#930

Broken.
Attachment #278235 - Flags: review?(bzbarsky)
Comment on attachment 278235 [details] [diff] [review]
Fast fix with 

This is the wrong fix.  The right fix is for this not to be MOZ_XUL.  See also bug 391100 comment 8.
Attachment #278235 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 2

10 years ago
Hmmm... I would glad to see that bug, but there are Access Denied
I didn't realize that promptservice was only built ifdef MOZ_XUL. You could just move nsAutoWindowStateHelper to its own file to fix this bug.
(Assignee)

Comment 4

10 years ago
May be it would be better move it inside nsPrompt.h|cpp files?
That's where it used to be, it got moved out to fix bug 389634

Comment 6

10 years ago
So, was nsWindowWatcher.cpp the wrong place to move it to, or was there a problem with how it was moved?
it was moved to nsPromptService.cpp, not to nsWindowWatcher.cpp. And yeah, it looks like that was not a good place to move it to. see comment 3.
(Assignee)

Comment 8

10 years ago
Created attachment 297552 [details] [diff] [review]
Fixed according to comment #3
Assignee: nobody → romaxa
Attachment #278235 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #297552 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #297552 - Flags: review? → review?(bzbarsky)
I won't get to this until June.  Please ask someone else for review.
(Assignee)

Comment 10

10 years ago
Comment on attachment 297552 [details] [diff] [review]
Fixed according to comment #3

Olli, could you check this patch?
Attachment #297552 - Flags: review?(bzbarsky) → review?(Olli.Pettay)

Comment 11

10 years ago
Comment on attachment 297552 [details] [diff] [review]
Fixed according to comment #3

This just moves code to a better place. r=me
Attachment #297552 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 297552 [details] [diff] [review]
Fixed according to comment #3

Moves XUL-only code to its own file.
Attachment #297552 - Flags: approval1.9?
Comment on attachment 297552 [details] [diff] [review]
Fixed according to comment #3

a1.9=beltzner
Attachment #297552 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
mozilla/embedding/components/windowwatcher/src/Makefile.in 	1.29
mozilla/embedding/components/windowwatcher/src/nsAutoWindowStateHelper.cpp 	1.1
mozilla/embedding/components/windowwatcher/src/nsAutoWindowStateHelper.h 	1.1
mozilla/embedding/components/windowwatcher/src/nsPromptService.cpp 	1.39
mozilla/embedding/components/windowwatcher/src/nsPromptService.h 	1.15
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Blocks: 671688
You need to log in before you can comment on or make changes to this bug.