393708 - Dragging an .xpi extension file onto Minefield browser window causes crash.

Status: RESOLVED DUPLICATE of bug 393309

(Firefox :: General, defect)

Description

[Michael Kraft [:morac]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082505 Minefield/3.0a8pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082505 Minefield/3.0a8pre

I upgraded to Gecko/2007082505 Minefield/3.0a8pre and now any time I try to install an extension by dragging the .xpi file onto the browser window, Minefield crashes.

Dragging the .xpi file onto the Addons window works fine.

Since CrashReporter always fails to submit crashes lately I don't have a link to the crash report.

This is a regression.

Reproducible: Always

Steps to Reproduce:
1. Save extension to file and drag .xpi file on to browser window.

Actual Results:  
Browser crashes

Expected Results:  
Installation window should pop up.

Comment 1

[Steve England [:stevee]]

Dupe of bug 393309?

Comment 2

[Michael Kraft [:morac]]

I don't think so since if I try to install the .xpi file from a web site I don't crash.  Only when I drag and drop the file on to the browser window.

Comment 3

[Michael Kraft [:morac]]

I managed to submit some crash dumps:

http://crash-stats.mozilla.com/report/index/458f34d1-538e-11dc-8f80-001a4bd43ed6?date=2007-08-26-04
http://crash-stats.mozilla.com/report/index/6826e223-538e-11dc-ad41-001a4bd43e5c?date=2007-08-26-04
http://crash-stats.mozilla.com/report/index/a3235ba8-538e-11dc-847a-001a4bd43e5c?date=2007-08-26-04

I compared it to the ones in bug 393309 and the both the location of the crash and the crash reason are different so I don't think it's a dupe.  In bug 393309 it is in mozilla/xpinstall/src/nsInstall.cpp:249 with a EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE, while in this case it is in mozilla/xpinstall/src/nsInstallTrigger.cpp:249 with a EXCEPTION_ACCESS_VIOLATION.

It may be related, but I don't think it's the same bug.

Comment 4

[Michael Kraft [:morac]]

Checking the CVS Blame it appears that it is dying on this line:
 uri->GetHost(host);

Since the file is local so there is no host, I'm guessing the GetHost doesn't like that.