Closed Bug 393753 Opened 17 years ago Closed 17 years ago

Go back to the group list is rendered inline with Yes, delete

Categories

(Bugzilla :: Administration, task)

3.1.1
task
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

Attached patch insert </p>Splinter Review
<h2>Confirmation</h2>

  <p>Do you really want to delete this group?</p>
    <p><b>You must check all of the above boxes or correct the
          indicated problems first before you can proceed.</b></p>

  <p><input type="submit" value="Yes, delete">
  <input type="hidden" name="action" value="delete">
  <input type="hidden" name="group" value="26">

  <input type="hidden" name="token" value="XEEZBritpl">
</form>

Go back to the <a href="editgroups.cgi">group list</a>.
Attachment #278279 - Flags: review?(vladd)
Assignee: administration → timeless
Flags: approval?
Flags: approval3.0?
OS: Mac OS X → All
Hardware: Macintosh → All
Target Milestone: --- → Bugzilla 3.0
Attachment #278279 - Flags: review?(vladd) → review+
Wouldn't it be nicer to keep them on the same line?
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
I suppose that decision could be made somewhere else. Here, lacking </p> is a bug.
(In reply to comment #2)
> I suppose that decision could be made somewhere else. Here, lacking </p> is a
> bug.

Only with HTML 4 Strict, not Transitional where </p> is optional. So I wouldn't approve this patch based on this argument only.
Comment on attachment 278279 [details] [diff] [review]
insert </p>

mozilla/webtools/bugzilla/template/en/default/admin/groups/delete.html.tmpl 	1.13

BUGZILLA-3_0-BRANCH:
mozilla/webtools/bugzilla/template/en/default/admin/groups/delete.html.tmpl 	1.10.2.1
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: