Closed
Bug 393923
Opened 17 years ago
Closed 17 years ago
"ASSERTION: Invalid offset" and "ASSERTION: aPos out of range" with rtl, :first-letter
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: roc)
References
Details
(Keywords: assertion, rtl, testcase)
Attachments
(2 files)
184 bytes,
text/html
|
Details | |
1.20 KB,
patch
|
smontagu
:
review+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file /Users/jruderman/trunk/mozilla/gfx/thebes/src/gfxSkipChars.cpp, line 92 ###!!! ASSERTION: aPos out of range: '0 <= aPos && aPos < mCharacterCount', file ../../../dist/include/thebes/gfxFont.h, line 563 Also, none of the letters gets the first-letter style.
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → roc
Flags: blocking1.9?
Comment 1•17 years ago
|
||
doesn't seem like this should assert but i don't get any characters in firefox2 so i'm not sure if we should block on this. thoughts?
Assignee | ||
Comment 2•17 years ago
|
||
We probably should, but this should be in Layout anyway so it's not your problem
Assignee: roc → nobody
Component: GFX: Thebes → Layout: Fonts and Text
QA Contact: thebes → layout.fonts-and-text
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → roc
Reporter | ||
Comment 3•17 years ago
|
||
I'd nominate this for blocking just because the assertions sound scary. (Also, the "Invalid offset" assertion can be triggered by lots of bugs, and having this fixed will make it easier to continue looking for such bugs.)
Assignee | ||
Comment 4•17 years ago
|
||
Stupid bug here, trivial fix. This fixes the assertions, but the first-letter isn't displayed as magenta. That must be a separate bug.
Attachment #278711 -
Flags: review?(smontagu)
Comment 5•17 years ago
|
||
I filed bug 393985 on this and other cases where the first-letter style isn't applied. (In reply to comment #1) > doesn't seem like this should assert but i don't get any characters in firefox2 > so i'm not sure if we should block on this. thoughts? That was bug 198928, FWIW
Updated•17 years ago
|
Attachment #278711 -
Flags: review?(smontagu) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #278711 -
Flags: approval1.9?
Comment on attachment 278711 [details] [diff] [review] fix assertions a1.9=dbaron
Attachment #278711 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 7•17 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: blocking1.9?
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite?
Reporter | ||
Comment 8•17 years ago
|
||
Crashtest checked in. Bug 393985 will eventually get a reftest.
Flags: in-testsuite? → in-testsuite+
Comment 9•16 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•