If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"ASSERTION: Invalid offset" and "ASSERTION: aPos out of range" with rtl, :first-letter

RESOLVED FIXED

Status

()

Core
Layout: Text
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Jesse Ruderman, Assigned: roc)

Tracking

(Blocks: 1 bug, {assertion, rtl, testcase})

Trunk
x86
Mac OS X
assertion, rtl, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 278484 [details]
testcase

###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file /Users/jruderman/trunk/mozilla/gfx/thebes/src/gfxSkipChars.cpp, line 92

###!!! ASSERTION: aPos out of range: '0 <= aPos && aPos < mCharacterCount', file ../../../dist/include/thebes/gfxFont.h, line 563

Also, none of the letters gets the first-letter style.
Assignee: nobody → roc
Flags: blocking1.9?

Comment 1

10 years ago
doesn't seem like this should assert but i don't get any characters in firefox2 so i'm not sure if we should block on this.  thoughts?
We probably should, but this should be in Layout anyway so it's not your problem
Assignee: roc → nobody
Component: GFX: Thebes → Layout: Fonts and Text
QA Contact: thebes → layout.fonts-and-text
Depends on: 384527
Assignee: nobody → roc
(Reporter)

Comment 3

10 years ago
I'd nominate this for blocking just because the assertions sound scary.  (Also, the "Invalid offset" assertion can be triggered by lots of bugs, and having this fixed will make it easier to continue looking for such bugs.)
Created attachment 278711 [details] [diff] [review]
fix assertions

Stupid bug here, trivial fix.

This fixes the assertions, but the first-letter isn't displayed as magenta. That must be a separate bug.
Attachment #278711 - Flags: review?(smontagu)
I filed bug 393985 on this and other cases where the first-letter style isn't applied.

(In reply to comment #1)

> doesn't seem like this should assert but i don't get any characters in firefox2
> so i'm not sure if we should block on this.  thoughts?

That was bug 198928, FWIW

Updated

10 years ago
Attachment #278711 - Flags: review?(smontagu) → review+
Attachment #278711 - Flags: approval1.9?
Comment on attachment 278711 [details] [diff] [review]
fix assertions

a1.9=dbaron
Attachment #278711 - Flags: approval1.9? → approval1.9+
checked in
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: blocking1.9?
Resolution: --- → FIXED
Flags: in-testsuite?
(Reporter)

Comment 8

10 years ago
Crashtest checked in.  Bug 393985 will eventually get a reftest.
Flags: in-testsuite? → in-testsuite+
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.