39394 - subscribe: STOP button needs to stop url that is running

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

right now, the cancel button doesn't stop the url that is running.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting.

Comment 2

[scottputterman]

nsbeta3 and M18

Comment 3

[selmer (gone)]

Adding mail4 triage nomination keyword.

Comment 4

[scottputterman]

reassigning to naving

Comment 5

[lchiang]

+ per mail triage

Comment 6

[Karen Huang]

Change the summary from "CANCEL button needs to stop url that is running" to 
"STOP button needs to stop url that is running".

Comment 7

[Karen Huang]

*** Bug 49681 has been marked as a duplicate of this bug. ***

Comment 8

[lchiang]

per mail triage:  Remove the Stop button from the Subscribe dialog.

Comment 9

[Diane Sun]

Found a fix for this, reassing to myself.

Comment 10

[Diane Sun]

Per lchiang's comment, if we decide to remove the "Stop" button, the fix goes to 
 mozilla/mailnews/base/resources/content/subscribe.xul.

Index: subscribe.xul
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/resources/content/subscribe.xul,v
retrieving revision 1.41
diff -c -r1.41 subscribe.xul
*** subscribe.xul       2000/08/14 21:43:13     1.41
--- subscribe.xul       2000/08/29 23:22:43
***************
*** 124,130 ****
            <button id="unsubscribe" class="dialog" value="&unsubscribeButton.la
bel;" oncommand="SetSubscribeState(false)"/>
            <button id="refresh" class="dialog" value="&refreshButton.label;" on
command="RefreshList()"/>
            <spring flex="1"/>
-           <button id="stop" class="dialog" value="&stopButton.label;" oncomman
d="Stop()"/>
          </box>
        </row>
      </rows>
--- 124,129 ----

Comment 11

[Diane Sun]

Checking in subscribe.xul;
/cvsroot/mozilla/mailnews/base/resources/content/subscribe.xul,v  <--  subscribe
.xul
new revision: 1.42; previous revision: 1.41
done

Comment 12

[Karen Huang]

So, after remove the "stop" button from the subscribe dialog, 
which button can stop url that is running? 

It seems that "Cancel" button is for dismiss the subscribe dialog, 
not for stop url that is running. 

Is this bug still implement the "stop url that is running" or just remove the 
stop button?

Comment 13

[lchiang]

The fix is the remove the Stop button.  Wouldn't closing the dlg automatically
stop the URL that is running?

Comment 14

[(not reading, please use [e-mail] instead)]

sadly, I don't think closing the dialog will stop the url.

Comment 15

[Karen Huang]

Based on UI Spec, Beta2 priorities and Seth comments, I am thinking we should 
have a way to perform "stop url that is running" functionality.
Ccing jglick who may provide more input for this bug.

http://gooey/client/5.0/specs/mail/Newsgroups/Subscribe.html#Subscribe
http://gooey/client/5.0/specs/mail/Newsgroups/Subscribe.html#Beta

And I need to reopen this bug since this bug is not original remove the "stop" 
button, we should have a way to implement "stop url that is running" if we still 
agree with the stop button removement......

Comment 16

[lchiang]

We have a bug that the Stop button does nothing.  For the release, we decided 
that we'll just remove the button.  There is still no way to stop the URL that 
is running.  That will not be fixed for nsbeta3. 

Karen, if you have verified that the Stop button is gone, then we will just 
"future" this bug for another release to put back the Stop button and make it 
function properly.

Removing nsbeta3 nomination and +.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Does this bug depend on bug 67555 (Start and stop throbber on timer (don't start
and stop for every url, or for quick operations)
?

Comment 18

[(not reading, please use [e-mail] instead)]

taking from dianne...

Comment 19

[(not reading, please use [e-mail] instead)]

marking fixed.  closing the dialog (with [X]), hitting stop, ok, and cancel will
all stop the url.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED.  Hitting Stop, Ok, Cancel works on Windows 2000, Linux and Mac. 
Hitting the "X" (Close window) is only present on Windows and Linux builds, but
works also.