39398 - subscribe: need icons in the tree and the menu list in the subscribe dialog

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

ui polish.

Comment 1

[(not reading, please use [e-mail] instead)]

ui polish.  m18.

Comment 2

[lchiang]

do you need icons from Jennifer?

Comment 3

[(not reading, please use [e-mail] instead)]

this bug is to track the necessary css / xul / datasource magic I need to do to
get icons to show in the subscribe dialog.

I'll check if there are other icons for subscribe that aren't already in the
tree.

Comment 4

[jglick]

Icons for News are here:
http://gooey/client/5.0/specs/visuals/icons/icon_mail/iconlist_mail.htm#8. 
Newsgroup list

Comment 5

[Henrik Gemal]

Any update on the missing icons?

Comment 6

[(not reading, please use [e-mail] instead)]

ok, I got a fix for this one.  I had to tweak the css and the xul and the
subscribe data source.

I'll attach a patch.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: here's the fix.

Comment 8

[(not reading, please use [e-mail] instead)]

adding keyword.

Comment 9

[David :Bienvenu]

sr = bienvenu

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: new patch, I forgot about the blue theme

Comment 11

[Syd Logan]

r=syd

Comment 12

[(not reading, please use [e-mail] instead)]

fixed.  thanks syd and bienvenu for the reviews.

Comment 13

[Karen Huang]

Verified on all the platforms: 
Linux 12-05-08-Mtrunk
WinNT 12-05-09-Mtrunk
Mac 12-05-08-Mtrunk
Icons are displaying in the tree and the menu list in the subscribe dialog now. 
Marking as verified.