394065 - switch perfmaster to new version of perfrunner.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Attachment: perfrunner cleaned up w/ multiplatform support

Attached to this bug is a new version of perfrunner.py. It contains all of the steps needed for baselining and on-checkin tests. I've been tested these for 4 or 5 days now and they work on all platforms. As an added bonus they use build properties to manage inter-step communication which means 'buildbot reconfig' works without messing up existing builds and builders. It should be a completely drop-in replacement.

I think it's pretty important to this soon so we can reconfig when necessary, and add new builders as necessary.

I'm thinking we can schedule a small amount of downtime over the weekend to make this change. It should have little impact on development that way. What do you think Rob?

Comment 1

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 278643 [details] [diff] [review]
perfrunner cleaned up w/ multiplatform support

I think this is great! I like what you've done with it. There's a commented section in MozillaInstallDmg::__init__()  that probably doesn't need to be there, butotherwise this looks solid. I'd like to take the MozillaChangePusher and put that into the baseliner as well. Good stuff.

Comment 2

[[e-mail] (:bhearsum)]

I attached the wrong file here...will fix in a bit.

Comment 3

[Rob Campbell [:rc] (:robcee)]

wow, you mean the new one's even better?

Comment 4

[[e-mail] (:bhearsum)]

Attachment: even better perfrunner.py

So, really the only thing new here is that all class variables (like filename, fileURL, etc.) have been made into instance variables. Class variables (in python, they are declared outside of a function) are shared by all instances of the class. That's why builders keep getting mixed up and pulling the wrong binaries.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 278959 [details] [diff] [review]
even better perfrunner.py

need mountdmg.exp as per irc dicsussion.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: expect script to mount dmg files on 10.4.9+

No cvs access so I can't make a patch.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: mountdmgexp.patch

Comment 8

[Rob Campbell [:rc] (:robcee)]

RCS file: /cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/mountdmg.exp,v
done
Checking in mountdmg.exp;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/mountdmg.exp,v  <--  mountdmg.exp
initial revision: 1.1
done

Comment 9

[Rob Campbell [:rc] (:robcee)]

cvs commit: Examining .
Checking in perfrunner.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/perfrunner.py,v  <--  perfrunner.py
new revision: 1.2; previous revision: 1.1
done

Comment 10

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.