Closed
Bug 394144
Opened 17 years ago
Closed 12 years ago
Missing keyboard accelerator on "Do not ask next time" in the new quit dialog
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
RESOLVED
FIXED
Firefox 23
People
(Reporter: mak, Assigned: Cykesiopka)
Details
Attachments
(1 file, 1 obsolete file)
2.08 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
The new quit dialog has keyboard accelerators for _Quit | _Save & Quit | _Cancel, but does not have any accelerator on "Do not ask next time".
An accelerator like A or N could be added there
Comment 2•17 years ago
|
||
This will not%block%Firefox 3.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
![]() |
Assignee | |
Comment 3•12 years ago
|
||
Attachment #727098 -
Flags: review?(mak77)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 727098 [details] [diff] [review]
Proposed Patch
redistributing reviews load
Attachment #727098 -
Flags: review?(mak77) → review?(paolo.mozmail)
Comment 5•12 years ago
|
||
Comment on attachment 727098 [details] [diff] [review]
Proposed Patch
Thank you for submitting the patch, and sorry for the late response.
I've noticed that this string is displayed only when the about:config option
"browser.showQuitWarning" is set to true. Did you test the patch after changing
this option manually?
If you verified that the new accelerator works, you should also make sure that
localizers get a chance to add the accelerator to their locale too. To do this,
the name of the string must be changed (for example, to "neverAsk2") and all
the references in the code should also be updated accordingly.
Attachment #727098 -
Flags: review?(paolo.mozmail)
![]() |
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Paolo Amadini [:paolo] from comment #5)
> Comment on attachment 727098 [details] [diff] [review]
> Proposed Patch
>
> Thank you for submitting the patch, and sorry for the late response.
>
> I've noticed that this string is displayed only when the about:config option
> "browser.showQuitWarning" is set to true. Did you test the patch after
> changing
> this option manually?
Yes.
> If you verified that the new accelerator works, you should also make sure
> that
> localizers get a chance to add the accelerator to their locale too. To do
> this,
> the name of the string must be changed (for example, to "neverAsk2") and all
> the references in the code should also be updated accordingly.
Sure. I'll attach a new patch soon!
![]() |
Assignee | |
Comment 7•12 years ago
|
||
+String name change
Assignee: nobody → cykesiopka
Attachment #727098 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #732030 -
Flags: review?(paolo.mozmail)
Comment 8•12 years ago
|
||
Comment on attachment 732030 [details] [diff] [review]
Patch v2
Looks good, thanks!
Attachment #732030 -
Flags: review?(paolo.mozmail) → review+
![]() |
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
Keywords: checkin-needed
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in
before you can comment on or make changes to this bug.
Description
•