394166 - Remove Utility Function usage, create using XPCOM in mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Nick Kreeger]

To help with the push to frozen linkage, mailnews needs to get rid of utility function calls for creating objects.

For example, there are many occurrences of |NS_NewISupportsArray|. Instead we should be using |do_CreateInstance(NS_SUPPORTSARRAY_CONTRACTID)|.

I suppose the best way to tackle this it to do it the same way we did the |nsXPIDL*| string removal, one at a time.

Comment 1

[Nick Kreeger]

Attachment: IMAP Fix V1

Here is the cleanup of all the classes in mailnews/imap that use the utility function.

Comment 2

[David :Bienvenu]

Comment on attachment 292162 [details] [diff] [review]
IMAP Fix V1

thx, Nick. One nit - I'm going to go out on a limb and say that things like this:

+        NS_ENSURE_TRUE(m_allFolders, NS_ERROR_FAILURE);

should return NS_ERROR_OUT_OF_MEMORY instead, or pass in &rv to do_CreateInstance and NS_ENSURE_SUCCESS(rv, rv) to be sure to get the right error code.

Comment 3

[Nick Kreeger]

Attachment: Checkin Patch Version [Checked In]

This patch addresses David's comments about getting the nsresult value to return in the NS_ERROR_FAILURE() calls.

Comment 4

[Nick Kreeger]

Comment on attachment 294304 [details] [diff] [review]
Checkin Patch Version [Checked In]

Checked into trunk.

Comment 5

[[e-mail]]

Actually nsISupportsArray is deprecated, and we should be looking into replacing it with nsI(Mutable)Array where possible.

Comment 6

[:aceman]

Should this stay open? The patch is marked checked in.

Comment 7

[Ludovic Hirlimann [:Usul]]

Nick why didn't you close the bug ?

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to [e-mail] from comment #5)
> Actually nsISupportsArray is deprecated, and we should be looking into
> replacing it with nsI(Mutable)Array where possible.

Is anything more needed?  If yes, should we close this and do meta with new bugs for "removal, one at a time"?

http://mxr.mozilla.org/comm-central/search?find=%2Fmailnews%2Fbase%2F&string=NS_NewISupportsArray ?

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #8)
> (In reply to [e-mail] from comment #5)
> > Actually nsISupportsArray is deprecated, and we should be looking into
> > replacing it with nsI(Mutable)Array where possible.

i.e. bug 394167.  which still has a couple unresolved bugs blocking it

Comment 10

[Wayne Mery (:wsmwk)]

mike, comment 8  (since everyone else punts)

Comment 11

[Mike Conley (:mconley) (:⚙️)]

My opinion: the goal of this bug is no longer valid, since, as Neil rightly points out, nsISupportsArray is deprecated in favour of nsIMutableArray.

Switching us over to nsIMutableArray seems to be tracked in bug 394167.

My position is to close this bug.

Comment 12

[Wayne Mery (:wsmwk)]

Using FIXED since it had one patch