can't drag favicon to an empty bookmarks toolbar

VERIFIED FIXED in Firefox 3 alpha8

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: dcamp, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Trunk
Firefox 3 alpha8
Points:
---
Bug Flags:
blocking-firefox3 +
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
When I have an empty bookmarks toolbar, dragging from the favicon doesn't create a bookmark there.  The purple caret shows up but when I drop, nothing is created and the caret doesn't go away.

Dragging from the bookmarks organizer works ok, and once there's another bookmark in the toolbar, dragging the favicon works too.

Updated

10 years ago
Flags: blocking-firefox3?
we're throwing an exception in TBV_DO_onDragOver(), in toolbar.xml

TypeError: this._self.lastChild has no properties

working on it.

Dave, thanks for the bug report!
Assignee: nobody → sspitzer
OS: Mac OS X → All
Hardware: PC → All
fix in hand
Status: NEW → ASSIGNED
Flags: in-litmus?
Target Milestone: --- → Firefox 3 M8
Created attachment 278913 [details] [diff] [review]
fix
Attachment #278913 - Flags: review?(mano)
Comment on attachment 278913 [details] [diff] [review]
fix

would (of course), take a review from dietrich as well.
Attachment #278913 - Flags: review?(dietrich)
Comment on attachment 278913 [details] [diff] [review]
fix

looks good, thanks for clearing up over irc.
Attachment #278913 - Flags: review?(dietrich) → review+
Comment on attachment 278913 [details] [diff] [review]
fix

seeking approval for m8
Attachment #278913 - Flags: review?(mano) → approval1.9?
Created attachment 280126 [details] [diff] [review]
updated patch, per mconnor's comment over irc
Attachment #278913 - Attachment is obsolete: true
Attachment #280126 - Flags: review?(mconnor)
Attachment #280126 - Flags: approval1.9?
Attachment #278913 - Flags: approval1.9?
Comment on attachment 280126 [details] [diff] [review]
updated patch, per mconnor's comment over irc

let's get this in tonight. thanks!
Attachment #280126 - Flags: review?(mconnor)
Attachment #280126 - Flags: review+
Attachment #280126 - Flags: approval1.9?
Attachment #280126 - Flags: approval1.9+
fixed.

Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.x
ml
new revision: 1.102; previous revision: 1.101
done

thanks again to dcamp for the bug report.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091322 Minefield/3.0a8pre ID:2007091322

VERIFIED
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED

Updated

10 years ago
Flags: blocking-firefox3? → blocking-firefox3+
https://litmus.mozilla.org/show_test.cgi?id=5026

in-litmus+
Flags: in-litmus? → in-litmus+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.