Closed Bug 394254 Opened 17 years ago Closed 17 years ago

nsInstallTrigger::HandleContent needs to nullcheck referringURI

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 393309

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

(Keywords: crash, topcrash)

Attachments

(1 file)

There can be a null referrer property, so the code needs to nullcheck it before using it

this doesn't exactly match the line numbers from the topcrash breakpad report but is what I can reproduce.
That was fixed in bug 393309
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
No longer blocks: 307770
Attached patch patchSplinter Review
Not quite sure whether passing an empty host in this case is the right thing to do...
Assignee: nobody → cbiesinger
Status: RESOLVED → ASSIGNED
Attachment #278869 - Flags: superreview?(dveditz)
Attachment #278869 - Flags: review?(mano)
Resolution: DUPLICATE → ---
Comment on attachment 278869 [details] [diff] [review]
patch

that's what I get for loading cvsblame URIs from socorro
Attachment #278869 - Flags: superreview?(dveditz)
Attachment #278869 - Flags: review?(mano)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: