Closed Bug 394261 Opened 14 years ago Closed 14 years ago

Update Hunspell to version 1.1.12

Categories

(Core :: Spelling checker, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Hunspell 1.1.8 to 1.1.11 patch (obsolete) — Splinter Review
I'm attaching a patch to update Hunspell to 1.1.11 as a checkpoint, but I'm going to hold off on requesting review until 1.1.12 is release, which Nemeth tells me is forthcoming.

What's new in 1.1.9 - 1.1.11:
-Fix for OpenSolaris build issue
-Fix for VC7.1 build issue
-Fix for Mingw build issue
-New phonetic transition table, allowing for spelling recommendations to be made on words with more than one letter swapped (ie. htne -> then & htikn -> think)
-Other various bug fixes (see the release notes at http://hunspell.sf.net for more info)

I've only tested this patch on VC8SP1, so it would be good to get some Linux test coverage. Also, Gavin, Ginn, and Martijn, can you make sure this still compiles OK on your platforms as a quick sanity check?
Compiled and works fine on Solaris
Thanks, compiled and works fine on windows mingw.
Hunspell 1.1.12 is out. On top of the changes given in comment #1, 1.1.12 also brings memory usage optimizations and a fix for the dreaded "alot" correction not being recommended :-).

Scott, you want to do the honors?
Attachment #278889 - Attachment is obsolete: true
Attachment #279816 - Flags: superreview?(mscott)
Attachment #279816 - Flags: review?(mscott)
Comment on attachment 279816 [details] [diff] [review]
Hunspell 1.1.8 to 1.1.12 patch

looks good to me. Hopefully, this can still get checked in, I know M8 is soon with more checkin restrictions to follow...
Attachment #279816 - Flags: superreview?(mscott)
Attachment #279816 - Flags: superreview+
Attachment #279816 - Flags: review?(mscott)
Attachment #279816 - Flags: review+
Comment on attachment 279816 [details] [diff] [review]
Hunspell 1.1.8 to 1.1.12 patch

Who needs to approve this for checkin?
Attachment #279816 - Flags: approval1.9?
Attachment #279816 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Summary: Update Hunspell to latest version → Update Hunspell to version 1.1.12
Checking in src/Makefile.in;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/Makefile.in,v  <--  Makefile
.in
new revision: 1.3; previous revision: 1.2
done
Checking in src/README.hunspell;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/README.hunspell,v  <--  READ
ME.hunspell
new revision: 1.4; previous revision: 1.3
done
Checking in src/affentry.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/affentry.cpp,v  <--  affentr
y.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in src/affixmgr.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/affixmgr.cpp,v  <--  affixmg
r.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in src/affixmgr.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/affixmgr.hxx,v  <--  affixmg
r.hxx
new revision: 1.3; previous revision: 1.2
done
Checking in src/atypes.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/atypes.hxx,v  <--  atypes.hx
x
new revision: 1.7; previous revision: 1.6
done
Checking in src/csutil.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/csutil.cpp,v  <--  csutil.cp
p
new revision: 1.4; previous revision: 1.3
done
Checking in src/csutil.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/csutil.hxx,v  <--  csutil.hx
x
new revision: 1.3; previous revision: 1.2
done
Checking in src/hashmgr.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/hashmgr.cpp,v  <--  hashmgr.
cpp
new revision: 1.4; previous revision: 1.3
done
Checking in src/hashmgr.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/hashmgr.hxx,v  <--  hashmgr.
hxx
new revision: 1.4; previous revision: 1.3
done
Checking in src/htypes.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/htypes.hxx,v  <--  htypes.hx
x
new revision: 1.3; previous revision: 1.2
done
Checking in src/hunspell.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/hunspell.cpp,v  <--  hunspel
l.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in src/hunspell.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/hunspell.hxx,v  <--  hunspel
l.hxx
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/extensions/spellcheck/hunspell/src/phonet.cpp,v
done
Checking in src/phonet.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/phonet.cpp,v  <--  phonet.cp
p
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/extensions/spellcheck/hunspell/src/phonet.hxx,v
done
Checking in src/phonet.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/phonet.hxx,v  <--  phonet.hx
x
initial revision: 1.1
done
Checking in src/suggestmgr.cpp;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/suggestmgr.cpp,v  <--  sugge
stmgr.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in src/suggestmgr.hxx;
/cvsroot/mozilla/extensions/spellcheck/hunspell/src/suggestmgr.hxx,v  <--  sugge
stmgr.hxx
new revision: 1.3; previous revision: 1.2
done

Checked into trunk.
Ryan, thanks for doing this!
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla1.9 M9 → mozilla1.9 M8
For information's sake, this changed trace_malloc_maxheap (MH) on Linux fxdbug-linux-tbox Dep from ~25.3MB to ~24.8MB
You need to log in before you can comment on or make changes to this bug.