Only cells with expanders should have STATE_EXPANDABLE and expand/collapse actions

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Joanmarie Diggs, Assigned: Aaron Leventhal)

Tracking

(Blocks: 1 bug, {access})

Trunk
x86
Linux
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Steps to reproduce:

1. Launch Accerciser and open the FF Bookmarks manager

2. Use Accerciser's Interface Viewer to examine the cells in the row containing "Mozilla Firefox" *in the scroll pane on the right* (i.e. the four-columned table).

Expected results: Only the cell that contains the expander (i.e. "Mozilla Firefox" in the Name column) would have STATE_EXPANDABLE and expand/collapse actions.

Actual results:  All cells in that row have STATE_EXPANDABLE and the associated expand/collapse actions.
(Assignee)

Comment 1

11 years ago
Created attachment 279264 [details] [diff] [review]
1) Create IsExpandable() for code re-use, 2) Only consider key column expandable, 3) Remove extra EXPANDABLE state computation (it's based on EXPANDED|COLLAPSED in nsAccessible.cpp)

Needs testing.
Attachment #279264 - Flags: review?(Evan.Yan)
(Assignee)

Comment 2

11 years ago
Created attachment 279265 [details] [diff] [review]
Minor change: 1) Create IsExpandable() for code re-use, 2) Only consider key column expandable, 3) Remove extra EXPANDABLE state computation (it's based on EXPANDED|COLLAPSED in nsAccessible.cpp)
Attachment #279264 - Attachment is obsolete: true
Attachment #279265 - Flags: review?(Evan.Yan)
Attachment #279264 - Flags: review?(Evan.Yan)
(Reporter)

Comment 3

11 years ago
I just did a quick check in the Bookmarks manager and it works very nicely there.  Building Thunderbird now....

Thanks Aaron!!
(Reporter)

Comment 4

11 years ago
I don't see any differences (i.e. regressions) in Thunderbird.

Updated

11 years ago
Attachment #279265 - Flags: review?(Evan.Yan) → review+
(Assignee)

Updated

11 years ago
Attachment #279265 - Flags: approval1.9?

Updated

11 years ago
Attachment #279265 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.