394387 - Only cells with expanders should have STATE_EXPANDABLE and expand/collapse actions

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

Steps to reproduce:

1. Launch Accerciser and open the FF Bookmarks manager

2. Use Accerciser's Interface Viewer to examine the cells in the row containing "Mozilla Firefox" *in the scroll pane on the right* (i.e. the four-columned table).

Expected results: Only the cell that contains the expander (i.e. "Mozilla Firefox" in the Name column) would have STATE_EXPANDABLE and expand/collapse actions.

Actual results:  All cells in that row have STATE_EXPANDABLE and the associated expand/collapse actions.

Comment 1

[Aaron Leventhal]

Attachment: 1) Create IsExpandable() for code re-use, 2) Only consider key column expandable, 3) Remove extra EXPANDABLE state computation (it's based on EXPANDED|COLLAPSED in nsAccessible.cpp)

Needs testing.

Comment 2

[Aaron Leventhal]

Attachment: Minor change: 1) Create IsExpandable() for code re-use, 2) Only consider key column expandable, 3) Remove extra EXPANDABLE state computation (it's based on EXPANDED|COLLAPSED in nsAccessible.cpp)

Comment 3

[Joanmarie Diggs]

I just did a quick check in the Bookmarks manager and it works very nicely there.  Building Thunderbird now....

Thanks Aaron!!

Comment 4

[Joanmarie Diggs]

I don't see any differences (i.e. regressions) in Thunderbird.