394520 - Switch urlbar history to sqlite

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

It's currently using an RDF container in localstore; to avoid getting bitten by a localstore sqlite conversion we should switch it in advance. I considered XML and prefs but thought sqlite would be easiest to write.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I know, not enough comments.

Comment 2

[jag (Peter Annema)]

Comment on attachment 279181 [details] [diff] [review]
Proposed patch

navigator.js also has |var gURIFixup|. That can be removed, right?

+    connection.executeSimpleSQL(
+        "DELETE FROM urlbarhistory WHERE ROWID NOT IN " +
+          "(SELECT ROWID FROM urlbarhistory ORDER BY ROWID DESC LIMIT 30)");

This could use a comment.


Index: common/pref/pref-history.xul

Don't you want to set isBtnDisabled to true if the file doesn't exist?

Comment 3

[[e-mail]]

Attachment: Addressed comments(!)

Comment 4

[[e-mail]]

Fix checked in.