394542 - we leak the blink timer and its timer in a cycle

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Whenever we use the blink timer, we leak the nsBlinkTimer and its nsTimerImpl in a cycle.  Right now we create a new nsTimerImpl each time the blink timer count goes above zero (nsBlinkTimer::Start), but we keep the same nsBlinkTimer around (since its mTimer owns it until we hit nsBlinkTimer::Start again).  Fixing the leak means they should either both stay around or both go away.  Making them both go away is a one-line patch, so I'll do that.

Note that fixing bug 330128 would also fix this.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Damon Sicore (:damons)]

Comment on attachment 279220 [details] [diff] [review]
patch

Please land ASAP, during the M8 freeze.

Comment 3

[Robert Sayre]

I landed this so it would make M8.

Checking in nsTextFrameThebes.cpp;
/cvsroot/mozilla/layout/generic/nsTextFrameThebes.cpp,v  <--  nsTextFrameThebes.cpp
new revision: 3.83; previous revision: 3.82
done

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This only got freeze approval because my approval request took a while to be processed, and was still hanging around after the freeze started.  But anyway...