Closed Bug 394545 Opened 17 years ago Closed 17 years ago

Remove intl.collationOption

Categories

(Core :: Internationalization, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

()

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Near as I can make out from bug 18338 and bug 62015, intl.collationOption was added because Red Hat 6.0 sorted Japanese in a broken way, and Netscape didn't want to ship Navigator 6.0 sorting email subjects wrong. Now, it has spread to cover the whole tree - the pref is only read in nsCollationUnix.cpp, but it's in the global-platform properties files for all platforms in two toolkits; every app prefs it to chrome://global-platform/ but it's also in global/intl.properties; nobody uses it: none of the toolkit locales (conveniently in CVS) have a value for it (other than invalid accidents), and the ja-JP SeaMonkey langpack doesn't set it, either.
Attachment #279223 - Flags: review?(smontagu)
Comment on attachment 279223 [details] [diff] [review]
Fix v.1

r+moa=smontagu (no sr required)
Attachment #279223 - Flags: review?(smontagu) → review+
Attachment #279223 - Flags: approval1.9?
Attachment #279223 - Flags: approval1.9? → approval1.9+
intl/locale/src/unix/nsCollationUnix.cpp 1.67
minimo/customization/all.js 1.46
toolkit/locales/en-US/chrome/global-platform/unix/intl.properties 1.4
toolkit/locales/en-US/chrome/global-platform/mac/intl.properties 1.4
toolkit/locales/en-US/chrome/global-platform/win/intl.properties 1.4
toolkit/locales/en-US/chrome/global/intl.properties 1.6
browser/app/profile/firefox.js 1.201
mail/app/profile/all-thunderbird.js 1.97
modules/libpref/src/init/all.js 3.690
xulrunner/app/xulrunner.js 1.8
calendar/sunbird/app/profile/sunbird.js 1.43
suite/locales/en-US/chrome/browser/unix/navigator.properties 1.3
suite/locales/en-US/chrome/browser/mac/navigator.properties 1.2
suite/locales/en-US/chrome/browser/win/navigator.properties 1.2
suite/locales/en-US/chrome/browser/navigator.properties 1.98
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
smontagu, Phil, 
as we try to keep our part of the tree (mozilla/calendar) mostly in sync between 1.8 branch and trunk, would it be harmful if we would apply this change to our branch copy of sunbird.js as well?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: