Closed Bug 394614 Opened 18 years ago Closed 18 years ago

Channels ending with a forward slash (/) cannot be opened at startup in chatzilla.

Categories

(Other Applications Graveyard :: ChatZilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: michaelgibbs, Assigned: Gijs)

Details

(Whiteboard: [cz-0.9.79])

Attachments

(1 file)

713 bytes, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6 Build Identifier: ChatZilla 0.9.78.1 When a channel such as #/a/ is set to open on startup, Chatzilla will instead open the channel with the same name minus the slash at the end (in this case #/a would be opened). Reproducible: Always Steps to Reproduce: 1. Join #channel/ on any server. 2. Right click on tab and choose to open at startup. 3. Restart Chatzilla. Actual Results: #channel opens. Expected Results: #channel/ should open.
Note that a workaround is adding "/j #channel/" to the commands used on connection to a server.
This should be an escaping issue. Fix should be pretty trivial, I think. Would like to get to this soon, not sure if that's actually going to happen.
Attached patch PatchSplinter Review
Ergh, silly thing. Only replaces one slash. James, can I have a rubberstamp, pretty please? :-D
Assignee: rginda → gijskruitbosch+bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #282111 - Flags: review?(silver)
OS: Windows Vista → All
Hardware: PC → All
Version: unspecified → Trunk
Comment on attachment 282111 [details] [diff] [review] Patch I'd suggest target.replace("/", "%2f", "g") but someone would hunt me down. ;) r=silver on your version
Attachment #282111 - Flags: review?(silver) → review+
Checking in mozilla/extensions/irc/js/lib/irc.js; /cvsroot/mozilla/extensions/irc/js/lib/irc.js,v <-- irc.js new revision: 1.109; previous revision: 1.108 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.79]
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: