394615 - 0 byte downloads don't appear in download manager

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: v1

Blank Active list. Dlmgr thinks there's an active download when quitting. Regressed with bug 390748.

This doesn't fix the problem of (I'm guessing) WBP not creating a blank file -- it doesn't make the output stream data->mStream until it gets an onDataAvail. Perhaps if it did MakeOutputStream at the end of OnStartRequest, it'll create a 0 byte file even if there are no writes??
http://mxr.mozilla.org/mozilla/source/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp#830

At least with this fixed, the finished "download" will show up correctly and not have dlmanager confused about uncompleted downloads when quitting.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 279293 [details] [diff] [review]
v1

r=sdwilsh

Comment 2

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/downloads/src/nsDownloadManager.h 	1.38 

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Can you file a bug on fixing this for real (i.e. in webbrowserpersist) instead of working around it in dl manager?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with build: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007090415 Minefield/3.0a8pre and a "File, Save Page As ..." / "Webpage, Complete".

"blank.htm" is saved corrently and displays "Done" status; exiting is also not a problem.

Comment 5

[Ed Lee :Mardak]

(In reply to comment #3)
> Can you file a bug on fixing this for real (i.e. in webbrowserpersist)
Filed bug 394992 

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4631

in-litmus+ (I need to find a more permanent location to host the blank file, but that'll come later.)