Closed Bug 394660 Opened 17 years ago Closed 17 years ago

incorrect instanceof check in linkToolbarOverlay.js

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

patch
970 bytes, patch
neil
: review+
Details | Diff | Splinter Review 
I don't know whether this patch is correct (or even where this code is used). The edge cases where this would actually cause a bug are probably never exercised, but I noticed it while searching MXR for other broken users of instanceof.
Attached patch patch — — Splinter Review 
Assignee: general → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #279360 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 279360 [details] [diff] [review]
patch

Nobody tried firing DOMLinkAdded on a non-link ;-)

        Attachment #279360 -
        Flags: review?(neil) → review+

    
    

    
  
mozilla/suite/browser/linkToolbarOverlay.js 	1.16 
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: