incorrect instanceof check in linkToolbarOverlay.js

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I don't know whether this patch is correct (or even where this code is used). The edge cases where this would actually cause a bug are probably never exercised, but I noticed it while searching MXR for other broken users of instanceof.
Created attachment 279360 [details] [diff] [review]
patch
Assignee: general → gavin.sharp
Status: NEW → ASSIGNED
Attachment #279360 - Flags: review?(neil)

Comment 2

11 years ago
Comment on attachment 279360 [details] [diff] [review]
patch

Nobody tried firing DOMLinkAdded on a non-link ;-)
Attachment #279360 - Flags: review?(neil) → review+
Keywords: checkin-needed
mozilla/suite/browser/linkToolbarOverlay.js 	1.16 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.