394661 - Add an XPCOM method to expose Distinguished Name (DN) parsing

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP XPCOM SDK, enhancement)

Description

[Jeremy Lainé]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070723 Iceweasel/2.0.0.6 (Debian-2.0.0.6-1)
Build Identifier: 

Currently, there is no method provided for applications to parse the Distinguished Name (DN) of an LDAP entry via XPCOM. To add writable LDAP support to mailnews, a method is needed which takes a DN and returns:

- the Relative DN,
- the Base DN,
- the attributes used to build the Relative DN


Reproducible: Always

Comment 1

[Jeremy Lainé]

Attachment: Add nsLDAPService::ParseDn() to expose DN parsing via XPCOM

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 279362 [details] [diff] [review]
Add nsLDAPService::ParseDn() to expose DN parsing via XPCOM

yep, looks good, r=me. Thanks for the patch.

Comment 3

[David :Bienvenu]

Comment on attachment 279362 [details] [diff] [review]
Add nsLDAPService::ParseDn() to expose DN parsing via XPCOM

looks good - it might be more readable if the strndup result were put into a temp here:

+        if (!(cArray[index] = nsCRT::strndup(*component, len))) {
+            NS_ERROR("nsLDAPService::ParseDn: out of memory ");

the var name cArray isn't very meaningful - maybe "attrNameArray"?

but I'll leave it up to Mark

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> (From update of attachment 279362 [details] [diff] [review])
> looks good - it might be more readable if the strndup result were put into a
> temp here:
> +        if (!(cArray[index] = nsCRT::strndup(*component, len))) {
> +            NS_ERROR("nsLDAPService::ParseDn: out of memory ");
> the var name cArray isn't very meaningful - maybe "attrNameArray"?
> but I'll leave it up to Mark

I think yes, it would be more more meaningful with a slightly better name.

Comment 5

[Jeremy Lainé]

Attachment: Add nsLDAPService::ParseDn() to expose DN parsing via XPCOM v2

I am attaching an updated version of the patch with these 2 changes:

1/ rename cArray to attrNameArray as requested
2/ use static_cast instead of NS_STATIC_CAST

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 280330 [details] [diff] [review]
 Add nsLDAPService::ParseDn() to expose DN parsing via XPCOM v2

r=me, thanks.

Comment 7

[Mark Banner (:standard8)]

Just remembered, we forgot about the uuid (if an interface changes in any way, then its uuid needs to be changed), so I've done that when I checked it in just now:

Checking in directory/xpcom/base/public/nsILDAPService.idl;
/cvsroot/mozilla/directory/xpcom/base/public/nsILDAPService.idl,v  <--  nsILDAPService.idl
new revision: 1.6; previous revision: 1.5
done
Checking in directory/xpcom/base/src/nsLDAPService.cpp;
/cvsroot/mozilla/directory/xpcom/base/src/nsLDAPService.cpp,v  <--  nsLDAPService.cpp
new revision: 1.28; previous revision: 1.27
done