394707 - `make package` broken for cross-compiles (not using host xpt_link)

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[:Mook]

Attachment: use $(XPIDL_LINK)

See URL.  The script hard-codes the copy of xpt_link in dist/bin, which means that `make package` fails when cross-compiling (because either xpt_link is not found, or it's for the wrong architecture).

Using $(XPIDL_LINK) seems happier for me, but that pulls in $(CYGWIN_WRAPPER) and I have no idea if that breaks cygwin builds.  Please test with one of those?

Comment 1

[Benjamin Smedberg]

Comment on attachment 279410 [details] [diff] [review]
use $(XPIDL_LINK)

it's likely that the additional CYGWIN_WRAPPER will be correct in the case where we're using cygwin perl. Feel free to check this in, but expect to backout if some of the tinderboxes (seamonkey especially) go red.

Comment 2

[:Mook]

Attachment: regenerated patch. diff hates me.

Presumably r+ and a+ carries over, because the only changes were to the crap before the actual diff :(  patch doesn't want to apply, apparently...

Comment 3

[Frank Wein [:mcsmurf]]

Checking in toolkit/mozapps/installer/packager.mk;
/cvsroot/mozilla/toolkit/mozapps/installer/packager.mk,v  <--  packager.mk
new revision: 1.52; previous revision: 1.51
done

Comment 4

[:Mook]

Thanks for the checkin, mcsmurf!