Closed Bug 394707 Opened 15 years ago Closed 15 years ago

`make package` broken for cross-compiles (not using host xpt_link)

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mook, Assigned: Mook)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch use $(XPIDL_LINK) (obsolete) — Splinter Review
See URL.  The script hard-codes the copy of xpt_link in dist/bin, which means that `make package` fails when cross-compiling (because either xpt_link is not found, or it's for the wrong architecture).

Using $(XPIDL_LINK) seems happier for me, but that pulls in $(CYGWIN_WRAPPER) and I have no idea if that breaks cygwin builds.  Please test with one of those?
Attachment #279410 - Flags: review?(benjamin)
Comment on attachment 279410 [details] [diff] [review]
use $(XPIDL_LINK)

it's likely that the additional CYGWIN_WRAPPER will be correct in the case where we're using cygwin perl. Feel free to check this in, but expect to backout if some of the tinderboxes (seamonkey especially) go red.
Attachment #279410 - Flags: review?(benjamin)
Attachment #279410 - Flags: review+
Attachment #279410 - Flags: approval1.9+
Presumably r+ and a+ carries over, because the only changes were to the crap before the actual diff :(  patch doesn't want to apply, apparently...
Assignee: nobody → mook.moz+mozbz
Attachment #279410 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Checking in toolkit/mozapps/installer/packager.mk;
/cvsroot/mozilla/toolkit/mozapps/installer/packager.mk,v  <--  packager.mk
new revision: 1.52; previous revision: 1.51
done
Thanks for the checkin, mcsmurf!
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 392438
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.