394778 - Unit tests in security/manager/ssl/tests not run

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

The xpcshell unit tests in security/manager/ssl/tests are not getting executed by the tinderboxes. It looks like "make check" just doesn't visit the directory since on my local machine doing "make -C security/manager/ssl check" runs the tests fine.

Comment 1

[Dave Townsend [:mossop]]

Attachment: make check target descend into ssl

The default check target descends to security/manager but with no XPCSHELL_TESTS defined does nothing. This patch then makes it further descend to security/manager/ssl which has XPCSHELL_TESTS defined and so the tests get executed.

The libs target is already set to descend to ssl so the tests are already getting copied to the appropriate places.

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 279493 [details] [diff] [review]
make check target descend into ssl

r=kengert

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 279493 [details] [diff] [review]
make check target descend into ssl

Requesting approval for this minor change that enables unit testing of the pipnss module.

Comment 4

[Rob Campbell [:rc] (:robcee)]

oh yes, please. a+ from me.

Comment 5

[Dave Townsend [:mossop]]

Checking in security/manager/Makefile.in;
/cvsroot/mozilla/security/manager/Makefile.in,v  <--  Makefile.in
new revision: 1.77; previous revision: 1.76
done