Unit tests in security/manager/ssl/tests not run

RESOLVED FIXED in mozilla1.9alpha8

Status

RESOLVED FIXED
11 years ago
9 months ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

unspecified
mozilla1.9alpha8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The xpcshell unit tests in security/manager/ssl/tests are not getting executed by the tinderboxes. It looks like "make check" just doesn't visit the directory since on my local machine doing "make -C security/manager/ssl check" runs the tests fine.
(Assignee)

Comment 1

11 years ago
Created attachment 279493 [details] [diff] [review]
make check target descend into ssl

The default check target descends to security/manager but with no XPCSHELL_TESTS defined does nothing. This patch then makes it further descend to security/manager/ssl which has XPCSHELL_TESTS defined and so the tests get executed.

The libs target is already set to descend to ssl so the tests are already getting copied to the appropriate places.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #279493 - Flags: review?(kengert)

Comment 2

11 years ago
Comment on attachment 279493 [details] [diff] [review]
make check target descend into ssl

r=kengert
Attachment #279493 - Flags: review?(kengert) → review+
(Assignee)

Comment 3

11 years ago
Comment on attachment 279493 [details] [diff] [review]
make check target descend into ssl

Requesting approval for this minor change that enables unit testing of the pipnss module.
Attachment #279493 - Flags: approval1.9?
oh yes, please. a+ from me.

Updated

11 years ago
Attachment #279493 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 5

11 years ago
Checking in security/manager/Makefile.in;
/cvsroot/mozilla/security/manager/Makefile.in,v  <--  Makefile.in
new revision: 1.77; previous revision: 1.76
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9 M8
Component: Testing → Build Config
QA Contact: testing → build-config

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.