394828 - clean up extensions.css

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch

Just took a look at extensions.css and found that it could do with some cleanup

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 279543 [details] [diff] [review]
patch

This looks good, but can you also change richlistbox to #extensionsView, it's more efficient for the style system.

Something I thought about with adding the security stuff is whether we should move some of the style rules out of the theme and into the bindings. I'm thinking specifically the ones for showing /hiding the buttons and status messages. I can't imagine third party themers wanting to alter that and it'd mean everytime we added such a change it wouldn't break all third party themes.

Comment 2

[Robert Strong (they/them - no direct email)]

Excellent suggestion... I'll resubmit

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

We might consider moving the hiding / unhiding of the badges and messages here but I'd prefer not to do that for M8

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 279637 [details] [diff] [review]
patch rev2

r=me

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.34; previous revision: 1.33
done
Checking in mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.30; previous revision: 1.29
done
Checking in mozilla/toolkit/mozapps/extensions/content/extensions.css;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.css,v  <--  extensions.css
new revision: 1.16; previous revision: 1.15
done