Closed Bug 394896 Opened 14 years ago Closed 14 years ago

Implement ARIA autocomplete

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

1) Support regular state HASPOPUP via ARIA state table, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if to save on perf
5.27 KB, patch
davidb
: review+
damons
: approval1.9+
Details | Diff | Splinter Review 
A new autocomplete property is being added to combobox and textbox roles.

Possible values:
off
inline
list
both
Attachment #280469 - Attachment description: c:\diff\394896.diff → 1) Support regular state HASPOPUP via ARIA state table -- all combo boxes and any textbox with autocomplete="list"|"both" uses STATE_HASPOPUP, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3)
Comment on attachment 280469 [details] [diff] [review]
1) Support regular state HASPOPUP via ARIA state table, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if to save on perf

Looks good. I assume we check specifically for "inline", "list", or "both" because the attribute value might be something like "none" or "off" etc?
Attachment #280469 - Flags: review?(david.bolter) → review+
That's right, there is a possible value of "off".
Attachment #280469 - Flags: approval1.9?
Attachment #280469 - Flags: approval1.9? → approval1.9+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 280469 [details] [diff] [review]
1) Support regular state HASPOPUP via ARIA state table, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if to save on perf

Attachment description too long.

Original description:
1) Support regular state HASPOPUP via ARIA state table -- all combo boxes and any textbox with autocomplete="list"|"both" uses STATE_HASPOPUP, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if, to save on perf

New description:
1) Support regular state HASPOPUP via ARIA state table, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if to save on perf
Attachment #280469 - Attachment description: 1) Support regular state HASPOPUP via ARIA state table -- all combo boxes and any textbox with autocomplete="list"|"both" uses STATE_HASPOPUP, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) → 1) Support regular state HASPOPUP via ARIA state table, 2) Support AUTOCOMPLETION state for any of the autocomplete types on both ARIA and natural textboxes/combos, 3) Reorganize code so single/multiline is calculated inside that if to save on perf
You need to log in before you can comment on or make changes to this bug.