Key off of name and description for grouping plugins

VERIFIED FIXED in mozilla1.9beta1

Status

()

VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla1.9beta1
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Per bug 391687 comment #37

Also see bug 199952
Flags: blocking-firefox3?
An example where keying off name and description would be better is if the user has multiple versions of flash installed (e.g., one in the Netscape 4.x directory, which we find, and one in the Mozilla directory) -- that shows up in the description but not the name.
Can you provide the names for these two? It seems that just keying off of the description would work in that case and everything other case I know of since the description is unique in all of the examples I know of.
Those are both "Shockwave Flash".

However, if a user managed to have multiple versions of QuickTime installed the names would be different but the descriptions wouldn't (since the version is in the name but not the description).
Thanks David... you saved me some time scrounging around for a plugin to test against.
Created attachment 280041 [details] [diff] [review]
patch -w
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #280041 - Flags: review?(dtownsend)
Comment on attachment 280041 [details] [diff] [review]
patch -w

r=me but I'm a little concerned about the sorting.

We currently rely on |for (var pluginName in gPlugins)| going over the plugin names in the order they were added to gPlugins. This appears to be working but I'm told that that behaviour is not defined by js, so changes to spidermonkey (the move to tamarin f.e.) might break that.
Attachment #280041 - Flags: review?(dtownsend) → review+
Right... this is just to get this working for Firefox 3.0 and we'll address that and quite a few other things for Moz2.
Works for me
Attachment #280041 - Flags: approval1.9?

Updated

11 years ago
Attachment #280041 - Flags: approval1.9? → approval1.9+
Checked in to trunk

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.150; previous revision: 1.149
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: blocking-firefox3? → blocking-firefox3+

Comment 11

11 years ago
Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; es-ES; rv:1.9a9pre) Gecko/2007100504 Minefield/3.0a9pre.  
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.