394978 - Key off of name and description for grouping plugins

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Per bug 391687 comment #37

Also see bug 199952

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

An example where keying off name and description would be better is if the user has multiple versions of flash installed (e.g., one in the Netscape 4.x directory, which we find, and one in the Mozilla directory) -- that shows up in the description but not the name.

Comment 2

[Robert Strong (they/them - no direct email)]

Can you provide the names for these two? It seems that just keying off of the description would work in that case and everything other case I know of since the description is unique in all of the examples I know of.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Those are both "Shockwave Flash".

However, if a user managed to have multiple versions of QuickTime installed the names would be different but the descriptions wouldn't (since the version is in the name but not the description).

Comment 4

[Robert Strong (they/them - no direct email)]

Thanks David... you saved me some time scrounging around for a plugin to test against.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch -w

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 280041 [details] [diff] [review]
patch -w

r=me but I'm a little concerned about the sorting.

We currently rely on |for (var pluginName in gPlugins)| going over the plugin names in the order they were added to gPlugins. This appears to be working but I'm told that that behaviour is not defined by js, so changes to spidermonkey (the move to tamarin f.e.) might break that.

Comment 8

[Robert Strong (they/them - no direct email)]

Right... this is just to get this working for Firefox 3.0 and we'll address that and quite a few other things for Moz2.

Comment 9

[Dave Townsend [:mossop]]

Works for me

Comment 10

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.150; previous revision: 1.149
done

Comment 11

[Tony Chung [:tchung]]

Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; es-ES; rv:1.9a9pre) Gecko/2007100504 Minefield/3.0a9pre.