395029 - when I delete items from folders on the personal toolbar, we don't update the generated items

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

when I delete items from folders on the personal toolbar, we don't update the generated items.

this covers three bugs, but they are all related.

two examples of this:

example #1:

1) create a new folder on the personal toolbar, open it to see "(Empty)"
2) drop one link into it
3) remove that link by opening the folder, right clicking on the link, deleting it.

expected results:  open the folder and you'd see "(Empty)"
actual results:    open the folder and you see nothing (or on windows, a little square, screen shot coming)

example #2:


1) create a new folder on the personal toolbar, open it to see "(Empty)"
2) drop two links into it
3) delete the first link, and you'll get:

actual results:

link #2
separator
Open in All in tabs

expected results:

link #2

4) now delete the second link, you'll get:


actual results:

separator
Open in All in tabs

expected results:

(Empty)

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the little square

Comment 2

[(not reading, please use [e-mail] instead)]

ass with bug #395028, on new window or restart, everything is correct.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 281075 [details] [diff] [review]
patch

r=me, thanks

Comment 5

[Asaf Romano (gone)]

mozilla/browser/components/places/content/menu.xml 1.83

Comment 6

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre

Comment 7

[Aakash Desai [:aakashd]]

Test cases were updated/created on 3.x test runs for regression testing.

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7539

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7472

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv