Allow QueryService from any accessible to IAccessibleApplication

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

(Blocks: 1 bug, {access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
JAWS expects to be able to QS from an IAccessible to an IAccessibleApplication.

Actually this should probably be on nsAccessNodeWrap. Our current QueryService impl should move there.
(Assignee)

Comment 1

11 years ago
Created attachment 279805 [details] [diff] [review]
Simple patch
Attachment #279805 - Flags: review?(surkov.alexander)

Comment 2

11 years ago
Comment on attachment 279805 [details] [diff] [review]
Simple patch

>Index: accessible/src/msaa/nsAccessNodeWrap.cpp

>+#include "AccessibleApplication.h"

nit: nsApplicationAccessibleWrap.h includes this file already.

>+STDMETHODIMP
>+nsAccessNodeWrap::QueryService(REFGUID guidService, REFIID iid, void** ppv)
>+{

nit: please add 'a' prefix to arguments.

> 
>+  public: // IServiceProvider
>+    STDMETHODIMP QueryService(REFGUID guidService, REFIID riid, void** ppv);

here too.

> STDMETHODIMP
>-nsAccessibleWrap::QueryService(REFGUID guidService, REFIID iid, void** ppv)
>-{
>-  /**
>-   * To get an ISimpleDOMNode, ISimpleDOMDocument or ISimpleDOMText
>-   * from an IAccessible you have to use IServiceProvider like this:
>-   * --------------------------------------------------------------
>-   * ISimpleDOMDocument *pAccDoc = NULL;
>-   * IServiceProvider *pServProv = NULL;
>-   * pAcc->QueryInterface(IID_IServiceProvider, (void**)&pServProv);
>-   * if (pServProv) {
>-   *   const GUID unused;
>-   *   pServProv->QueryService(unused, IID_ISimpleDOMDocument, (void**)&pAccDoc);
>-   *   pServProv->Release();
>-   * }
>-   */

btw, should we do for document accessible similar things with application accessible?
Attachment #279805 - Flags: review?(surkov.alexander)
Attachment #279805 - Flags: review+
Attachment #279805 - Flags: approval1.9?
(Assignee)

Comment 3

11 years ago
No, just application accessible.

Updated

11 years ago
Attachment #279805 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.