395077 - Allow QueryService from any accessible to IAccessibleApplication

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

JAWS expects to be able to QS from an IAccessible to an IAccessibleApplication.

Actually this should probably be on nsAccessNodeWrap. Our current QueryService impl should move there.

Comment 1

[Aaron Leventhal]

Attachment: Simple patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 279805 [details] [diff] [review]
Simple patch

>Index: accessible/src/msaa/nsAccessNodeWrap.cpp

>+#include "AccessibleApplication.h"

nit: nsApplicationAccessibleWrap.h includes this file already.

>+STDMETHODIMP
>+nsAccessNodeWrap::QueryService(REFGUID guidService, REFIID iid, void** ppv)
>+{

nit: please add 'a' prefix to arguments.

> 
>+  public: // IServiceProvider
>+    STDMETHODIMP QueryService(REFGUID guidService, REFIID riid, void** ppv);

here too.

> STDMETHODIMP
>-nsAccessibleWrap::QueryService(REFGUID guidService, REFIID iid, void** ppv)
>-{
>-  /**
>-   * To get an ISimpleDOMNode, ISimpleDOMDocument or ISimpleDOMText
>-   * from an IAccessible you have to use IServiceProvider like this:
>-   * --------------------------------------------------------------
>-   * ISimpleDOMDocument *pAccDoc = NULL;
>-   * IServiceProvider *pServProv = NULL;
>-   * pAcc->QueryInterface(IID_IServiceProvider, (void**)&pServProv);
>-   * if (pServProv) {
>-   *   const GUID unused;
>-   *   pServProv->QueryService(unused, IID_ISimpleDOMDocument, (void**)&pAccDoc);
>-   *   pServProv->Release();
>-   * }
>-   */

btw, should we do for document accessible similar things with application accessible?

Comment 3

[Aaron Leventhal]

No, just application accessible.