395078 - Extension launch button doesn't show up on trunk

Status: RESOLVED DUPLICATE of bug 395466

(Other Applications Graveyard :: QA Companion, defect)

Description

[Ben Hsieh]

Well, this sucks. Testing on Win trunk shortly.

Comment 1

[Ben Hsieh]

Bad news: Bug appears on Windows also.

Mitigating news: This seems to just be a display issue. You can still launch the extension by clicking on a narrow strip of window where the button used to be, on Windows. Doesn't seem to be a corresponding strip of window on OSX.

Comment 2

[Ben Hsieh]

Must be something different on trunk. Nothing's changed in our packaged version for a few weeks now, and it definitely worked at some point.

Comment 3

[Ben Hsieh]

See https://bugzilla.mozilla.org/show_bug.cgi?id=395099 

I'll upload a patch using style= attribute instead of src= attribute in the meantime.

Comment 4

[Ben Hsieh]

Attachment: v1

Can't get rid of the newline warnings. I wonder if that means that the original file had no newline at end of file? I definitely have one there now. Anyways, if it's a problem let me know (or just fix it).

Comment 5

[Ben Hsieh]

There's a patch that got r+'d in 395099 that should resolve this problem for us without the patch (it was actually a XUL problem, surprise surprise). 

Still, moving images to css probably isn't a bad idea. I'll downgrade this bug to minor or something once we can confirm that our code (whatever we end up sticking with) works on trunk again.

Comment 6

[cmtalbert]

Duping this against the current bug with the current version of the code (including this code's patch.)