395140 - leave preferred app when setting action to something else in Applications prefpane

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

When a user sets an action to something other than "use helper app" in the new Applications prefpane, the prefpane removes the preferred app from the datastore.  Perhaps we should keep it around, since legacy datastores don't include the preferred app in the list of possible apps, and that means removing the preferred app from the datastore will remove it from the list of possible actions.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: leaves preferred app

After thinking about this further, I think we should indeed leave the preferred app when we set the action to something else, since there aren't any downsides that I can see, and this will keep the preferred app on the list of possible apps in legacy datastores.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 280819 [details] [diff] [review]
patch v1: leaves preferred app

Requesting approval to land this in M9.  This patch is low risk and fixes a problem that will bite some subset of folks using the new Applications prefpane who upgraded from Firefox 2.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.3; previous revision: 1.2
done