395141 - use a generic icon for types and apps that don't have one in the Applications prefpane

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

When types don't have an icon in the applications prefpane, we show nothing.  We might consider showing a generic icon instead.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

faaborg, what's your thought on this issue?  Should we display a generic icon for types that don't have a type-specific icon, or should we just display no icon at all?

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

I think we should display a generic icon for types that don't have one to maintain visual balance, and the same for applications.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Alex, do you have some icons in mind?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

I've added these to the icon inventory, please use the temporary icons until
the professional icons are made:
http://people.mozilla.com/~faaborg/files/granParadisoUI/icons/iconInventory.html

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Note the use of a different icon for plugins

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Thanks Alex!  One question: will there be a different set of icons for Linux, or should I be reusing the Windows icon for that OS?

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

My understanding is that linux will use the xp theme by default.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

It looks like we are switching from a puzzle piece as the universal addons icon to a lego style block, updated the icon inventory: http://people.mozilla.com/~faaborg/files/granParadisoUI/icons/iconInventory.html

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: adds generic icons in most cases

This patch adds generic icons in the following cases:

1. types without icons on Windows and Linux;
2. apps (whether default, preferred, or possible) without icons on all platforms.

It doesn't add generic icons for types without icons on Mac because of bug 397823.  In addition to adding generic icons, I also updated the Options.png images with the temporary icon for the Applications prefpane.

I'll attach the graphic files as a ZIP file shortly.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Attachment: images v1: generic type and app icons plus prefpane icon

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: unrotted

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 282810 [details] [diff] [review]
patch v2: unrotted

The icons in the dropdowns don't seem to be aligned with the icons on the selected item, could you file a followup bug on that? The "jitter" that occurs when you select an item and it expands is also sub-optimal, but it might not be easily avoidable without making either the dropdown too small or the "normal" entries too big.

Comment 14

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #13)
> (From update of attachment 282810 [details] [diff] [review])
> The icons in the dropdowns don't seem to be aligned with the icons on the
> selected item, could you file a followup bug on that?

Yup, I have filed bug 398443 on it.

> The "jitter" that occurs when you select an item and it expands is also
> sub-optimal, but it might not be easily avoidable without making either the
> dropdown too small or the "normal" entries too big. 

Indeed, but if there is a solution it would be good to implement it, so I've filed bug 398445 on it.

Comment 15

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v3: the version i checked in

Here's the version I checked in.  It's identical to patch v2 except that it replaces one instance of a Windows line-ending character sequence (CR+LN) in applications.js, which snuck in as part of the checkin for bug 397690, with the correct Unix-style character (LN), per Gavin's request that I do this the next time I check in a change to that file.

Comment 16

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.16; previous revision: 1.15
done
Checking in browser/components/preferences/handlers.xml;
/cvsroot/mozilla/browser/components/preferences/handlers.xml,v  <--  handlers.xml
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.62; previous revision: 1.61
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.58; previous revision: 1.57
done
Checking in browser/themes/pinstripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/Options.png,v  <--  Options.png
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/application.png,v
done
Checking in browser/themes/pinstripe/browser/preferences/application.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/application.png,v  <--  application.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/plugin.png,v
done
Checking in browser/themes/pinstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/plugin.png,v  <--  plugin.png
initial revision: 1.1
done
Checking in browser/themes/winstripe/browser/preferences/Options.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/Options.png,v  <--  Options.png
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/application.png,v
done
Checking in browser/themes/winstripe/browser/preferences/application.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/application.png,v  <--  application.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v
done
Checking in browser/themes/winstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v  <--  plugin.png
initial revision: 1.1
done

Comment 17

[Dão Gottwald [:dao]]

This is inconsistent with bug 391670.

Comment 18

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #17)
> This is inconsistent with bug 391670.

Hmm, interesting.  The plugin icon I used was the one in the icon inventory referenced in comment 5, but that inventory doesn't list the plugin icon anymore.

Comment 19

[Alex Faaborg [:faaborg] (Firefox UX)]

>but that inventory doesn't list the plugin icon anymore.

Sorry, doing some maintenance on the icon inventory.  The interlocking brick icon is still the current choice for our universal addon icon, but we may switch it to a puzzle piece.  I'll comment in this bug if it changes so our temp icons remain consistent.

Comment 20

[Alfred Kayser]

Attachment: Optimized version of the png's

The application.png and plugin.png are much smaller when passed through PngOptimizer:
Before:
26-09-2007  18:05             3.100 application.png
26-09-2007  18:40               452 plugin.png
After:
05-12-2007  09:10               344 application.png
05-12-2007  09:10               414 plugin.png

Especially application.png is now 11% of what it used to be...

Comment 21

[Alex Faaborg [:faaborg] (Firefox UX)]

Note that these icons are just placeholders, are are going to be replaced along with nearly every other icon.  We will likely want to run everything through pngOptimizer at the end, to see how much space we can save and to see if it has any impact on performance.