395143 - allow users to set types to "always ask" in the Applications prefpane

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

Currently users can't reset types to "always ask" in the Applications prefpane.  That's because the old code did that.  And it didn't make much sense given that types that were already set to "always ask" were hidden, so allowing this would have meant allowing users to shoot themselves in the foot by setting a type to "always ask" and then having that type disappear from the list.

But now that we're going to let you configure types set to "always ask" (per bug 395138), we should let you reset types to "always ask" as well.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

If we wontfix bug 395138, then we might wontfix this bug as well, although I suppose one could argue that it still makes sense to let users set types to always ask even if means those types subsequently disappear from the prefpane.

Comment 2

[Jesper Kristensen]

(In reply to comment #1)
I don't think this depends on bug 395138. If this bug is wontfix'ed, users would have no way of undoing their action when they check the "Always use this app for this type of content" checkbox in the download dialog.

If bug 395138 is wontfix'ed, we should probably keep the content type in the list until the preference dialog is closed.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #2)
> (In reply to comment #1)
> I don't think this depends on bug 395138. If this bug is wontfix'ed, users
> would have no way of undoing their action when they check the "Always use this
> app for this type of content" checkbox in the download dialog.

Hmm, indeed.  They used to be able to do this by removing the type from the list, but they can't do that anymore now that we've fixed bug 395636.


> If bug 395138 is wontfix'ed, we should probably keep the content type in the
> list until the preference dialog is closed.

Yes, agreed.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Now that we've fixed bug 395636, users can't remove types from the list.  It turns out that used to be the way users reset a type back to the default action "always ask", so now there's no way to set a type back to the default action.

Which makes this pretty important to fix.  And this has implications for bug 395138, since it would be weird for a user to set a type to "always ask" and then not see that type the next time they returned to the prefpane.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Note: the patch in bug 395138 fixes this bug too.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Fixed by the fix for bug 395138.

Comment 8

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre and Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US;rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre on Fedora F8

-> Verified