Closed
Bug 395150
Opened 18 years ago
Closed 18 years ago
fillDoc() shouldn't trudge through each form if there are no stored logins for site
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: Dolske, Assigned: Dolske)
Details
Attachments
(1 file)
|
2.56 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
Bug 378667 added a countLogins() interface, which can be used to count the number of logins stored for a site without needing to compare against a specific actionURL. This can be used by fillDoc() to bail out early when there are no logins stored for the site (it currently steps through each form, because findLogins() needs a specific actionURL).
Attachment #279869 -
Flags: review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #279869 -
Flags: review?(gavin.sharp) → review+
|
||
Updated•18 years ago
|
Assignee: nobody → dolske
|
Assignee | |
Updated•18 years ago
|
Attachment #279869 -
Flags: approval1.9?
|
||
Updated•18 years ago
|
Attachment #279869 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 1•18 years ago
|
||
Checked in.
cvs commit: Examining toolkit/components/passwordmgr/src
Checking in toolkit/components/passwordmgr/src/nsLoginManager.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/src/nsLoginManager.js,v <-- nsLoginManager.js
new revision: 1.19; previous revision: 1.18
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
|
|
||
Comment 2•18 years ago
|
||
This seems to have improved Tp by 1-2%! Most excellent.
|
||
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•