fillDoc() shouldn't trudge through each form if there are no stored logins for site

RESOLVED FIXED in mozilla1.9beta1

Status

()

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

Trunk
mozilla1.9beta1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Created attachment 279869 [details] [diff] [review]
Patch for review, v.1

Bug 378667 added a countLogins() interface, which can be used to count the number of logins stored for a site without needing to compare against a specific actionURL. This can be used by fillDoc() to bail out early when there are no logins stored for the site (it currently steps through each form, because findLogins() needs a specific actionURL).
Attachment #279869 - Flags: review?(gavin.sharp)
Attachment #279869 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → dolske
(Assignee)

Updated

12 years ago
Attachment #279869 - Flags: approval1.9?
Attachment #279869 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 1

12 years ago
Checked in.

cvs commit: Examining toolkit/components/passwordmgr/src
Checking in toolkit/components/passwordmgr/src/nsLoginManager.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/src/nsLoginManager.js,v  <--  nsLoginManager.js
new revision: 1.19; previous revision: 1.18
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
This seems to have improved Tp by 1-2%!  Most excellent.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.