395173 - ctrl dragging bookmarks - releasing ctrl before releasing mouse button no longer removes copy function

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[mmortal03]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090304 Firefox/3.0a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090304 Firefox/3.0a6pre

When ctrl dragging bookmarks, releasing ctrl before releasing mouse button no longer removes the copy function.  This is a regression.

Reproducible: Always

Steps to Reproduce:
1. hold ctrl
2. click and drag bookmark, do not release mouse button
3. release ctrl
Actual Results:  
The plus on the dragged icon, and the copy function remains active.

Expected Results:  
releasing ctrl should have the dragged icon fall back to being just a move function instead of a copy function.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

confirmed on 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090612 Minefield/3.0a8pre

this works on Branch

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

fixed by patch in bug 418671

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080920033605 Minefield/3.1b1pre

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As Marco pointed out on IRC we don't have d&d tests yet. Means, we should add this d&d behavior as a testcase on Litmus.

Marco, on OS X this action can be accomplished by holding down the alt key while dragging the item. But we don't have a visual indicator to differentiate between copy and move. Is there a bug filed on that?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #3)
> Marco, on OS X this action can be accomplished by holding down the alt key
> while dragging the item. But we don't have a visual indicator to differentiate
> between copy and move. Is there a bug filed on that?

not that i'm aware of

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Alex, could you please give an answer to comment 3?

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

We should be using cursor changes to indicate what action will occur.  For instance on OS X a copy is shown with a green ball with a + on it, while a move is shown by dragging a ghosted image of the item (which we currently support).  On Vista copy is a blue +, and move is a blue arrow "->."  We could design cursors for XP that resemble the interface of Vista, but match the XP color palette.  Either way, something we should consider targeting for 3.2.

Comment 7

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=7475 has been created in litmus for regression testing.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv