395195 - Review new sk search plugin for FX3

Status: VERIFIED FIXED

(Mozilla Localizations :: sk / Slovak, defect)

Description

[Branislav Rozbora (Mozilla.sk)]

Attachment: azet-sk searchplugin

We want to add new search plugin into sk trunk builds. Please review it.

Azet.sk is one of the most popular and top search sites in Slovakia, providing also many other sections like news, chat, email etc.

Comment 1

[Mic Berman]

thanks, will check into it, and get back to you. do we have permission from
them to include their search engine?
thanks
mic

Comment 2

[Branislav Rozbora (Mozilla.sk)]

yes, we have their permission. They asked us if we could add it into browser. Do you need their permission explicitly?

Comment 3

[Mic Berman]

if you can send me either post here or by email a contact name or (even better) an email forwarded from them with their explicit permission that'd be great.

Also, in terms of suggesting to include azet.sk, I presume that you would like to add them because they create a better user experience and not just because they asked us and are popular. is that right?

thanks
mic

Comment 4

[Branislav Rozbora (Mozilla.sk)]

Mic, you should have permission from Renata Dubcova in your inbox now.
Yes, you are right. I metioned that they asked us just to show you, that there won't any be any problem with their permission.

Comment 5

[Mic Berman]

Hi
I received permission thanks!
two more clarifying questions please
1 - can you confirm the order of your search engine list then (this would be an addition I assume, vs replacing anything) 
2 - do you know if they wrote their own engine?

thanks again
mic

Comment 6

[Branislav Rozbora (Mozilla.sk)]

Attachment: list

Comment 7

[Branislav Rozbora (Mozilla.sk)]

1 - see attachment. yes, this is addition
2 - they are using local search engine called JYXO

Comment 8

[Mic Berman]

thanks
what is the difference between
azet-sk
atlas-sk
zoznam-sk

they all look like local search engine providers? whereas dunaj looks like a shopping specialty engine. I'm sorry if i'm asking obvious questions.

Comment 9

[Branislav Rozbora (Mozilla.sk)]

Basically yes, they are local search providers and Dunaj is shopping specialty engine. We are thinking about replacing eBay with local auction/store website. Do you thing it's goog idea? eBay doesn't provide localized content for users in Slovakia. If you can take a short look, those are our candidates: 
www.hej.sk (as online store)
www.onetwosold.sk (as auction website)
Is this reasonable for you? (we haven't contact them yet)

Comment 10

[Mic Berman]

first question:
if they are all the same, why do we want to list all of them? why not the best of them? (if there is a 'best')

second on replacing eBay, if I understand it correctly
the advatage of ebay vs. hej.sk or onetwosold.sk is that eBay allows users to sell their own stuff too as well as search others. i'm not sure if hej or ontwosold allows users to do that?

Comment 11

[Branislav Rozbora (Mozilla.sk)]

Well, they are not seach providers just like google, they are search providers from our point of view, when we are talking about FX search plugins. They are information, lifestyle, fun, chat sites etc., providing search as their another service. They are different in this way. For example azet.sk is the most popular for young people, because they are also providing chat engine, zoznam.sk provides "serious" informations just like phone numbers catalogue etc., atlas.sk is also lifestyle site. They are providing also email service, hostings etc.

This means, that they have different sort of users and those users prefer their search engines. According to our research, they are popular on the same level for FX users. So it would be great, if they could be integrated into FX3 installation.

According to Xiti Monitor Research (http://www.xitimonitor.com/en-us/browsers-barometer/firefox-july-2007/index-1-2-3-102.html), Firefox has 40! % market share in Slovakia and we are in top 3 European countries. One of the reasons of this success is, that users in Slovakia found their favourite sites included in FirefoX. That's one of the reasons, why we what to add azet.sk as another search engine, so more users could be glad.
And that's the reason, why we want to change rss feed from bbc to Sme.sk and also eBay. To become FX more popular. We are sure, that this can increase number of Firefox users in Slovakia.

All of them are also helping us with promoting Firefox for free, what is very important for us.

So, we will be glad, if all of them could be integrated in FX installation. If this is not possible, it will be hard to choose one (or two) of them and many users in Slovakia could be disappointed after that.

hej.sk is a store, so you cannot sell anything there. onetwosold.sk is auction web site just like eBay, so you can buy and sell there of course.

Comment 12

[Mic Berman]

Branislav,
thank you very much for the more detailed explanation now I understand why you want to include them all.

you have approval to do so, now over to axel on that part

on dropping or replacing ebay. i'm not sure if we should. i'm trying to find out if any users use them at all now. if there are users who use them in sk then I'd say let's leave them in so we don't offend any existing users. what do you think?

Comment 13

[Axel Hecht [:Pike]]

Is that plugin utf-8 encoded? I'm having problem with the description, it shows unknown glyphs on the mac.

Comment 14

[Branislav Rozbora (Mozilla.sk)]

Attachment: azet-sk searchplugin utf-8

No it isn't, sorry for that, utf8 version attached...
Mic, thanks for approval. eBay - ok, we will leave it as it is now.

Comment 15

[Axel Hecht [:Pike]]

Comment on attachment 280916 [details]
 azet-sk searchplugin utf-8

technical r-, we should really just send those paramaters that have values, i.e., sq and kde (with value internet).

This is in sync with what  I learned from azet.sk via mail.

The rest looks good, though.

Could you create a real patch with the changes?

Comment 16

[Branislav Rozbora (Mozilla.sk)]

Attachment: azet-sk searchplugin final

I removed next strings:

- <Param name="i9" value=""/>
- <Param name="idCompanyProduct" value=""/>
- <Param name="openFrom" value=""/>

Comment 17

[Branislav Rozbora (Mozilla.sk)]

what do you mean by "real patch" ?
i dont know how to make patch when there is no file on server

Comment 18

[Axel Hecht [:Pike]]

You want to do a 

cvs add azet-sk.xml

cvs -z3 diff -uN

and attach that output. As long as you don't cvs ci, the added file will only be added locally. The -N option to cvs diff will include the full file into the diff (as long as it's a text file, that is, for the sake of completeness).

Comment 19

[Branislav Rozbora (Mozilla.sk)]

Attachment: azet-sk searchplugin patch

Comment 20

[Axel Hecht [:Pike]]

Comment on attachment 282268 [details] [diff] [review]
azet-sk searchplugin patch

In the future, please add me as requesteee on such patches, otherwise they'll drop on the floor.

r=me based on the previous discussion, this is good to land.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 282263 [details]
azet-sk searchplugin final

Clearing the review on the plugin, the patch rules.

Comment 22

[Branislav Rozbora (Mozilla.sk)]

Already committed, marking fixed

Comment 23

[Mic Berman]

Branislav
for my records i realized i don't have a contact for permission for Dunaj (I believe we did this in Firefox 2 release). do you have a contact on file you can forward to me please.
thanks
mic

Comment 24

[Branislav Rozbora (Mozilla.sk)]

you should have e-mail with permission in your inbox now (again)

Comment 25

[Mic Berman]

received from Mgr. Alžbeta Čižmárová, thanks!

Comment 26

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008040706 Minefield/3.0pre