395268 - show a tag button instead of the star button if the current url is tagged

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

show a tag button instead of the star button if the current url is tagged

see also bug #395267 and bug #395257, where we will be showing the tag icon in url bar autocomplete results and in bookmark organizer search results.


I claim that tagging is greater than a bookmark.  meaning if something is both bookmarked and tagged, the tagging outweighs that.  (you can be bookmarked without being tagged, but not vice versa.)

dietrich points out some issues.  from irc:

<dietrich> hrm. there's currently no way (via the UI) to tag something w/o bookmarking it first
<sspitzerMsgMe> right, but:
<sspitzerMsgMe> if we show tag icon in the url bar results
<sspitzerMsgMe> and in the search results
<sspitzerMsgMe> I think we should consider showing the tag icon in the url bar
<sspitzerMsgMe> to match the tag icon in the results
<dietrich> well, the icon technically isn't in the url bar now
<dietrich> but that's a separate issue
<sspitzerMsgMe> hmm, good point
<sspitzerMsgMe> for people who don't tag, this is a non issue
<dietrich> hm, IMO the value of iconic consistency outweighs the value of tag vs. bookmark
<sspitzerMsgMe> but if you do tag, I think it might be useful to see that tag icon
<sspitzerMsgMe> let me start a bug with what I'm thinking, and cc you faaborg and mconnor
<dietrich> i think having mixed icons there send mixed messages about the purpose of the button
<sspitzerMsgMe> hmm, that's a good point
<sspitzerMsgMe> except that click on it does bring up the tag editor, no?
<dietrich> as well as the bookmark property fields...

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

My personal opinion on this change is that it improves UI in that it gives the user some chance of possibly guessing why the first result somehow relates to what they typed in (if they both notice the icon, understand the metaphor, and remember that they tagged the page with the same text).  However, I still contend that bug #393508 is a preferable user interface when dealing with matches against things other than the URL, like the title, tags, or full page text.

Comment 2

[(not reading, please use [e-mail] instead)]

alex, I think your comment is more for bug #395267.  this bug is about the star/unstar button next to the url bar.

Comment 3

[Jesse Ruderman]

I don't think this is a good idea.  It's not relevant information, and it wouldn't improve consistency.  (Bug 395257 says the "star icon" vs. "tag icon" distinction tells you the *reason for the match*, not simply whether the bookmark has tags.)

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Seth: I misread the title, thought we were talking about auto-complete results.  I don't think we should change the star icon in the location bar, it needs to have two clear states: empty and full.  I think a three state icon will over load the control with too much complexity.

Also, I would like to de-emphasize the tag icon, and just use the specific text with the grey outline appearance in nearly every case we deal with tags.  The only place the tag icon is currently used across all of the mockups is in the source list on the left of the places organizer.

Comment 5

[(not reading, please use [e-mail] instead)]

jesse and alex, thanks for the feedback.  I think dietrich felt the same way from his irc comments.

marking wontfix.

about de-emphasizing the tag icon, you may want to comment in bug #395267 and bug #395257.