Closed
Bug 395272
Opened 17 years ago
Closed 17 years ago
toolkit/toolkit-makefiles.sh should include uriloader/exthandler/tests directory
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(1 file)
511 bytes,
patch
|
bzbarsky
:
approval1.9+
|
Details | Diff | Splinter Review |
According to biesi, the toolkit/toolkit-makefiles.sh file should contain an entry for the uriloader/exthandler/tests directory.
Attachment #279970 -
Flags: review?(benjamin)
Comment 1•17 years ago
|
||
Trivial changes to the *makefiles.sh files like this one have blanket rs=bsmedberg and don't require bugs (see bug 394464 comment 2 and bug 379159 comment 1).
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 279970 [details] [diff] [review] patch v1: adds directory Normally these changes don't even require bugs and have blanket rs=bsmedberg (see gavin's comment 1), but requesting approval for this trivial, obvious change since we're in threat level orange, and thus all toolkit changes require approval.
Attachment #279970 -
Flags: review?(benjamin) → approval1.9?
Updated•17 years ago
|
Attachment #279970 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 3•17 years ago
|
||
Checking in toolkit/toolkit-makefiles.sh; /cvsroot/mozilla/toolkit/toolkit-makefiles.sh,v <-- toolkit-makefiles.sh new revision: 1.5; previous revision: 1.4 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•