395274 - Implement forum design

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[JT Batson]

This is a tracking bug for: Implement design of forum homepage, search results page and thread page.

Comment 1

[Jason Barnabe (np)]

Attachment: patch

Comment 2

[Jason Barnabe (np)]

Attachment: comment-footer.tpl

Comment 3

[Jason Barnabe (np)]

Attachment: comment-header.tpl

Comment 4

[Jason Barnabe (np)]

Attachment: comment-body.tpl

Comment 5

[Jason Barnabe (np)]

Attachment: before screenshot

Comment 6

[Jason Barnabe (np)]

Attachment: after screenshot

Comment 7

[Jason Barnabe (np)]

Also need to change short_date_format in tiki_preferences to %b %d, %Y

So the patches and the new files make the main area of a thread page much closer to the mockup at http://babyhook.com/SUMO/Forum_Designs_Round4/SUMO_threads.jpg

Open issues:
-Uses a gray line instead of a curvy fady corner
-Need a no-avatar avatar
-Not tested in other browsers
-Would like the date to be the date in the user's time zone

Even with these issues, it's much better than what was there before. I'd like to put this in and then work on these issues while getting feedback from others.

Comment 8

[David Tenser [:djst]]

(In reply to comment #7)
> So the patches and the new files make the main area of a thread page much
> closer to the mockup at
> http://babyhook.com/SUMO/Forum_Designs_Round4/SUMO_threads.jpg

That mockup is an older version. This is the latest mockup: http://blog.mozilla.com/sumo/2007/10/

I'd be happy to discuss the mockup with you, Jason, if you have time for it anytime soon. There are some things that I think could be tweaked.

Comment 9

[Nelson Ko [:nkoth]]

Comment on attachment 290947 [details] [diff] [review]
patch

You can set this in the admin...forums panel under the option "Display thread configuration bar to override defaults". Patch not needed.

Comment 10

[Nelson Ko [:nkoth]]

I was referring to the patch for tiki-setup.php. The rest has been committed to support-stage.

Comment 11

[Jason Barnabe (np)]

OK, this is in production now. Still more to do.

One problem I've noticed is that avatars aren't showing in article feedback because of the URL rewrite. Will fix this later.

Comment 12

[Jason Barnabe (np)]

Also, long text shows up below the user info box instead of beside.

Comment 13

[Jason Barnabe (np)]

Attachment: patch for comment area

The avatar issue isn't related to the path. It's because the pref to show avatars is forums-only.

This patch fixes the long comment problem. It also simplifies the reply area for forum threads and the comment area for articles for logged-in users.

Comment 14

[Jason Barnabe (np)]

Attachment: reply area, before

Comment 15

[Jason Barnabe (np)]

Attachment: reply area, after

Comment 16

[Jason Barnabe (np)]

Attachment: patch for comment area 2

Put the submit before before the preview so it's the default button.

Comment 17

[Nelson Ko [:nkoth]]

latest patch in support-stage. But I have added a way to set the default number of rows of the text area from the admin panel. Do it there instead. tiki-admin.php?page=textarea (Admin Home... Text Area)

Comment 18

[Jason Barnabe (np)]

Attachment: patch for preview

Makes the preview area just display the text and not the author or any other info, makes the header "Preview" instead of "Reply to the selected post", and adds a bit of spacing.

Nelson, do you know why when you press Preview the text doesn't stay in the textarea?

Comment 19

[Nelson Ko [:nkoth]]

the reason why the text does not stay in textarea is because the {if} that causes the replies to be blank for the "forum replies are blank" feature is wrong. This has been fixed on support-stage.

should be
{if $prefs.feature_forum_replyempty ne 'y' || $comment_preview eq 'y'}
instead of just the first part

Comment 20

[Jason Barnabe (np)]

I'm fairly happy with the way things work now. There are still improvements to make, but nothing that stops us from launching the forums, from my point of view. I say we should mark this as fixed and file bugs for the things from the mockups that we don't have.

Thoughts?

Comment 21

[David Tenser [:djst]]

I would at least remove the text "[Info Icon]" in step 3 of http://support-stage.mozilla.org/tiki-view_forum.php?topics_offset=2&forumId=1. I meant we should use an icon there, not a placeholder. :)

Comment 22

[Jason Barnabe (np)]

Already suggested that in bug 396581.

Comment 23

[David Tenser [:djst]]

Jason, I think it's fine if the forum design is a work in progress. The important thing is that we're on track with the release. The design in its current state is good enough for release.

Good work!