395395 - Application icons are only shown for a few programs

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[u88484]

Attachment: screenshot

In the new file handling tab, application icons are only shown for a few programs.  For me only firefox and notepad.

Expected:  All should have an icon

Comment 1

[u88484]

Also due to not having icons for everything, upon selection the entry moves to the left like seen with the selected entry in the screenshot.  

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I see this on Mac and Linux as well.  It looks like it's the plugins that don't have icons, although I notice that "Live Bookmarks" also doesn't have an icon.  Changing the summary to reflect this.

Comment 3

[u88484]

Hmm my winzip did not have an icon until I went ahead and made winzip once again the default for that mime type...showed up after restart.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> Hmm my winzip did not have an icon until I went ahead and made winzip once
> again the default for that mime type...showed up after restart.

Hmm, there may be a couple of bugs here.

Comment 5

[u88484]

Yeah I was waiting for this bug before filing any others because the icon should fix at least two more that I have up my sleeve waiting to file.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Hmm, I don't think this is actually a regression, as plugins didn't have icons in the old Download Actions and Change Action dialogs either.  It's not clear whether preferred applications (which is what winzip was before you made it the default for that MIME type, after which it become the default application) had icons.

Default applications certainly did, but they still do.  And Live Bookmarks is only a handler for web feeds, which was never a part of the old dialog.

So I'm inclined to say that this is not a regression but rather a followup enhancement to the new prefpane, which makes it a dependency on the original bug rather than a blocker of that bug.  Marking it accordingly.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

This will get fixed when we institute generic icons for types and applications that don't have their own, so setting the appropriate dependency on bug 395141, although it'd be useful to still think about how we might be able to get type- and application-specific icons for the ones that don't currently have them.

Comment 8

[u88484]

After seeing bug 395141, blah.  I know the icon is not permanent but I thats not what is blah. It is having like 50 of the same icon for plugins that have icons if I click the drop down.  Like wmp has an icon in that list but the wmp plugin doesnt.  Wmp is wmp. I can see an argument for wmp opens in an external application whilst wmp plugin opens it in the browser but still, its using wmp to play that video.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #8)
> After seeing bug 395141, blah.  I know the icon is not permanent but I thats
> not what is blah. It is having like 50 of the same icon for plugins that have
> icons if I click the drop down.  Like wmp has an icon in that list but the wmp
> plugin doesnt.  Wmp is wmp. I can see an argument for wmp opens in an external
> application whilst wmp plugin opens it in the browser but still, its using wmp
> to play that video.

I'm not sure I understand the issue.  Can you explain more specifically the difference between the icons for the WMP application and the WMP plugin and what you think the icons should be?

Comment 10

[u88484]

Attachment: should use WMP icon here

Should use the WMP icon here instead of the generic one, WMP is WMP.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #10)
> Created an attachment (id=283701) [details]
> should use WMP icon here
> 
> Should use the WMP icon here instead of the generic one, WMP is WMP.

Thanks for the visual, I understand the issue now.  So, I think this would be better tracked as a distinct bug, something like "consider using plugin-specific icons for plugins".  I'm going to resolve this one fixed now that all applications have icons via the fix for bug 395141, but please do file a bug on the issue that plugins don't have their own icons.