395413 - With the Dusk skin, text enclosed in <a name=""></a> is displayed in blue

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

Many places use <a name="foo">some text</a> to easily point to some portion of a page. But the Dusk skin displays all these strings in blue, as if they were real links. That's confusing and not really nice from a visual point of view. So we should only display text in blue if it's really a link. No idea how to do that in CSS (at least not from the top of my head).

Comment 1

[Max Kanat-Alexander]

You have to make your links <a name="something"></a>Text. You can't enclose the text in the anchor. This is a well-known issue that only shows up in Firefox.

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> You have to make your links <a name="something"></a>Text. You can't enclose the
> text in the anchor.

Of course you can, and is even recommended by the spec:
http://www.w3.org/TR/html4/struct/links.html#h-12.2

They even explicitly say that: "User agents should be able to find anchors created by empty A elements, but some fail to do so."

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

I use this trick for years on a website I'm managing.

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 280162 [details] [diff] [review]
patch, v1

The underline on hover is removed on IE7, but it's still blue there. We may need some entries in IE-fixes.css.

It works on Firefox, so I'm willing to make this r+ if we agree to fix IE separately.

Comment 5

[Frédéric Buclin]

Marc, can you help with IE7? I have Linux and Windows 2000, so I cannot install IE7.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Patch 2

Taking bug as agreed on IRC.

Here's a patch which works on both IE7 and FF2. Frédéric, can you please test it on IE6?

On a side note, I'd like to understand why it's necessary to mention a:link:hover near the beginning of the patch. I'd've thought that this is covered by a:link, but it apparently isn't.

Comment 7

[Frédéric Buclin]

Comment on attachment 280245 [details] [diff] [review]
Patch 2

Tested successfully with Firefox 2.0.0.6 (Windows 2000 + Linux), Opera 9.23 (Linux), IE6 SP1 (Windows 2000) and Konqueror 3.5.6 (Linux). r=LpSolit

Comment 8

[Marc Schumann [:Wurblzap]]

Checking in skins/contrib/Dusk/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/contrib/Dusk/global.css,v  <--  global.css
new revision: 1.2; previous revision: 1.1
done