Closed
Bug 395426
Opened 17 years ago
Closed 17 years ago
Contextmenu opened using keyboard should have .button == 0
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: regression)
Attachments
(2 files)
671 bytes,
application/xhtml+xml
|
Details | |
7.60 KB,
patch
|
enndeakin
:
review+
jst
:
superreview+
jst
:
approval1.9+
|
Details | Diff | Splinter Review |
This is a regression from Bug 354694. Because 1.8 reports .button == 0, I think we should keep that functionality.
Assignee | ||
Comment 1•17 years ago
|
||
Neil, could you test this on Windows.
Attachment #280100 -
Flags: review?(enndeakin)
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
Assignee | ||
Comment 2•17 years ago
|
||
Automated tests http://www.mozilla.pettay.fi/moztests/context_for_local_testing.xhtml though, that is just testing windowutils.
Comment 3•17 years ago
|
||
Comment on attachment 280100 [details] [diff] [review] proposed patch >- button = eRightButton; >+ button = (context == eNormal) ? eRightButton : eLeftButton; > } > } > #ifdef NS_DEBUG > ~nsMouseEvent() { >- NS_WARN_IF_FALSE(message != NS_CONTEXTMENU || button == eRightButton, >+ NS_WARN_IF_FALSE(message != NS_CONTEXTMENU || >+ button == >+ ((context == eNormal) ? eRightButton : eLeftButton), I think these checks would be easier to understand if there were written as: (context == eContextMenuKey) ? eLeftButton : eRightButton
Attachment #280100 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #280100 -
Flags: superreview?(jst)
Updated•17 years ago
|
Attachment #280100 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Updated•17 years ago
|
Attachment #280100 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #280100 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•