Closed Bug 395448 Opened 15 years ago Closed 15 years ago

Replace UI icons in the download manager

Categories

(Toolkit :: Downloads API, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9beta3

People

(Reporter: mossop, Assigned: sdwilsh)

References

Details

Attachments

(4 files, 1 obsolete file)

Many of the icons used in the new download manager UI are from an external icon set. They should be replaced with our own new icons. Once that's done the icons should be removed from tree and the credit for them added in bug 392000 removed (not just a straight backout of that patch).
Flags: blocking-firefox3?
However, when time is ready for this patch, please remember to backout the whitespace addition that the patch in bug 392000 added at the bottom, as it was unnecessary.
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: uiwanted
Target Milestone: --- → Firefox 3 M10
Priority: -- → P3
Target Milestone: Firefox 3 M10 → Firefox 3 M11
And note that even if our own icons fall through the cracks and we wind up still using the FAMFAMFAM ones, something has to be done here, since this currently pushes the about:license link up into unclickable territory when the scrolling stops.
There are licensing issues with sticking with the famfamfam ones; if there is a suggestion we might want to do that, I need to know about it.

Gerv
The icons for the add-ons manager are in the production queue.  We won't be using the FAMFAMFAM ones.
Blocks: 392128
What's the status on this?  Please note that the download manager icons need to be larger than they currently are to fix Bug 392128.
Whiteboard: [needs status update]
>What's the status on this?

We hope to have files to you before beta 3.
Assigning to Madhava since he's the UX team contact for the download manager.
Assignee: nobody → madhava
Summary: Replace UI icons → Replace UI icons in the download manager
Removing uiwanted since we are now in the process of producing the icons.
Keywords: uiwanted
Shawn: I'm not going to uploading these tonight, I'll try to get them to you tomorrow.
Attached image screenshot
screenshot of mac with new images - I'll file a follow-up for the mac theme to get their own.
Assignee: madhava → sdwilsh
Status: NEW → ASSIGNED
Nice!

(In reply to comment #12)
> Created an attachment (id=299892) [details]
> screenshot
> 
> screenshot of mac with new images - I'll file a follow-up for the mac theme to
> get their own.
> 

Attached patch v1.0 (obsolete) — Splinter Review
Lands XP icons for windows and mac (mac theme bug fileup coming soon, but we need famfamfam icons out).  Also adds the disabled pause button for linux.
Attachment #299894 - Flags: review?(mano)
Comment on attachment 299894 [details] [diff] [review]
v1.0

r=me on the Gnomestripe CSS.
Attachment #299894 - Flags: review+
Comment on attachment 299894 [details] [diff] [review]
v1.0

For correctness, please use a [disabled="true"] selector.

r=mano otherwise.
Attachment #299894 - Flags: review?(mano) → review+
Attached patch v1.1Splinter Review
addresses review comments
Attachment #299894 - Attachment is obsolete: true
Whiteboard: [needs status update] → [has patch][has review][can land]
Blocks: 414497
Bug for mac theme icons is bug 414497

Checking in toolkit/themes/pinstripe/mozapps/downloads/buttons.png;
new revision: 1.4; previous revision: 1.3
Checking in toolkit/themes/pinstripe/mozapps/downloads/downloads.css;
new revision: 1.24; previous revision: 1.23
Checking in toolkit/themes/winstripe/mozapps/downloads/buttons.png;
new revision: 1.3; previous revision: 1.2
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
new revision: 1.27; previous revision: 1.26
Checking in browser/base/content/credits.xhtml;
new revision: 1.32; previous revision: 1.31
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
new revision: 1.5; previous revision: 1.4
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/buttons-aero.png,v
done
Checking in toolkit/themes/winstripe/mozapps/downloads/buttons-aero.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/buttons-aero.png,v  <--  buttons-aero.png
initial revision: 1.1
done
Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008020218 Minefield/3.0b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020218 Minefield/3.0b3pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020204 Minefield/3.0b3pre (Ubuntu, which uses Gnome)
Status: RESOLVED → VERIFIED
There is an accessibility problem with these icons on Windows XP.  They are not very well visible when the download is selected, as the selection background is blue, too.  (At least with the Win Media Centre Edition visual style.)
>They are not
>very well visible when the download is selected, as the selection background is
>blue, too.

This will be fixed in the next icon drop.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.