395491 - Fix files copied over from gfx for compilation

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Peter Weilbacher]

With bug 394857 fixed we now have
   nsGfxDefs.h
   nsOS2Uni.cpp nsOS2Uni.h
   nsPaletteOS2.cpp nsPaletteOS2.h
   nsPrintOS2.cpp nsPrintOS2.h
in widget/src/os2. When bug 389729 has gone in we can cvs remove the old versions in GFX. To make them compile correctly, we at least need to
   - add the .cpp files to widget/src/os2/Makefile.in
   - remove the NS_GFX and NS_GFX_ macros

I think we can begin to look at removing the palette handling stuff from the widget code which means that nsPaletteOS2.* would be obsolete, too. I did a quick test running cairo builds under 256 colors and the webpages actually displayed nicer than 1.8 branch builds with palette handling, but the colors of e.g. tooltips were a bit weird. If that is the whole problem we should perhaps just change the requirements in README.txt to say that 256 should work but deep color is recommended. Actually that's already similar to what it says about the Modern theme...

Comment 1

[Peter Weilbacher]

Attachment: [checked in] Step1, remove NS_GFX*

OK, this is the first step to remove the NS_GFX macros. This stuff is now only used from widget and hence doesn't need to be exported any more.
Will check this in as a bustage fix soon.

Comment 2

[Dave Yeo]

With this fix the build once again completes.

Comment 3

[Peter Weilbacher]

Comment on attachment 280182 [details] [diff] [review]
[checked in] Step1, remove NS_GFX*

OK, after confirmation from Dave and Andy (bug 371505 comment 35) I checked this into trunk.

Still leaving bug open to look into palette issues.

Comment 4

[Peter Weilbacher]

Attachment: [checked in] Step2, remove palette stuff

This would remove all the palette handling stuff and other cruft. Still not really sure if that would be the right thing to do, but here it works mostly. Just tested again with 8bit depth, running PMView in parallel. Given that the default themes are much more colorful than 8 years ago when this was originally implemented I doubt that it makes sense to really support 256 colors (or less).

Alternatively, we could just leave the palette stuff in and try to fix the HPS handling in gfx/thebes that would need palette stuff added if anybody ever complains about this.

Comment 5

[Peter Weilbacher]

Mike, what do you think? Is the palette stuff something you are proud of and would like it to stay? :-)

Comment 6

[Mike Kaply [:mkaply]]

The palette stuff was a nightmare and i would love to never have to see it again :)

Comment 7

[Peter Weilbacher]

OK, so let's get rid of it then. I'll take the previous comment as a r+ (that I forgot to ask for) and check this patch in and CVS remove the nsPaletteOS2.* files.

Comment 8

[Peter Weilbacher]

Comment on attachment 294597 [details] [diff] [review]
[checked in] Step2, remove palette stuff

Checked this in just now.

Comment 9

[Peter Weilbacher]

Done with this one, too. :-)