Change assertions to real errors in mozStorageStatement.cpp

RESOLVED FIXED in mozilla1.9beta1

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9beta1
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
We need to actually error out and not just assert here...
(Assignee)

Comment 1

11 years ago
Created attachment 281511 [details] [diff] [review]
v1.0

This makes me happier :)
Attachment #281511 - Flags: review?(sspitzer)
Comment on attachment 281511 [details] [diff] [review]
v1.0

r=sspitzer, but EscapeStringForLIKE() doesn't need mDBConnection or mDBStatement to be called, so perhaps remove that change
Attachment #281511 - Flags: review?(sspitzer) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 281591 [details] [diff] [review]
v1.1

Good point, updated accordingly.
Attachment #281511 - Attachment is obsolete: true
Attachment #281591 - Flags: approval1.9?
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 281591 [details] [diff] [review]
v1.1

a=bzbarsky
Attachment #281591 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 5

11 years ago
Checking in storage/src/mozStorageStatement.cpp;
new revision: 1.28; previous revision: 1.27
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.