Closed Bug 395526 Opened 14 years ago Closed 14 years ago

Change assertions to real errors in mozStorageStatement.cpp

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Details

Attachments

(1 file, 1 obsolete file)

We need to actually error out and not just assert here...
Attached patch v1.0 (obsolete) — Splinter Review
This makes me happier :)
Attachment #281511 - Flags: review?(sspitzer)
Comment on attachment 281511 [details] [diff] [review]
v1.0

r=sspitzer, but EscapeStringForLIKE() doesn't need mDBConnection or mDBStatement to be called, so perhaps remove that change
Attachment #281511 - Flags: review?(sspitzer) → review+
Attached patch v1.1Splinter Review
Good point, updated accordingly.
Attachment #281511 - Attachment is obsolete: true
Attachment #281591 - Flags: approval1.9?
Target Milestone: --- → mozilla1.9 M9
Comment on attachment 281591 [details] [diff] [review]
v1.1

a=bzbarsky
Attachment #281591 - Flags: approval1.9? → approval1.9+
Checking in storage/src/mozStorageStatement.cpp;
new revision: 1.28; previous revision: 1.27
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.