Closed Bug 395527 Opened 17 years ago Closed 17 years ago
Create a .autoreg file so that we ensure the registry is up to date in shipped release builds
I discovered earlier that we're trying to ship a .autoreg file in our windows packaging but we don't actually generate it for it to be shipped. Talking to benjamin on irc, it sounds like its a bit old but we probably should be shipping one by default anyway. Looking at the code in http://mxr.mozilla.org/seamonkey/source/xpcom/build/nsXPComInit.cpp#290 if we haven't got a .autoreg file, then we're not going to be trying to rebuild the registry (compreg.dat) when we install a new build. I think this could lead to all sorts of weird things, possibly the problems we're seeing with the windows builds not always running. Anyway, looking at the code I think its best to ship with it, especially given its a zero-sized file. The attached code does this in the same way as xulrunner/firefox.
Attachment #280189 - Flags: review?(neil)
Comment on attachment 280189 [details] [diff] [review] Add .autoreg generation to the app makefile Can this not be added to the end of the Makefile?
Attachment #280189 - Flags: review?(neil) → review+
(In reply to comment #1) > (From update of attachment 280189 [details] [diff] [review]) > Can this not be added to the end of the Makefile? > I've checked this in as-is. I didn't want to put it at the end of the file to ensure that mac picks it up.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
(In reply to comment #2) >I didn't want to put it at the end of the file to ensure that mac picks it up. 1. The libs:: at the end of the file is obviously outside any if 2. The if is actually for mac, so accidentally putting it inside would still mean that the mac picked it up ;-)
OK, so KaiRo points out that anything after that mac ifdef won't get packaged - does that include the licen(s)e? Then what's it doing there? If it needs to be moved, please leave a comment not to put anything at the end :-)
Yesy, I wonder if the file from the libs:: section at the end of the file even ends up inside the mac app package at all. I'd feel better if we moved that one up into the section that Mark created in this bug, as that surely gets picked up on mac, being before that .app creation step in the if block.
You need to log in before you can comment on or make changes to this bug.