Closed Bug 395528 Opened 17 years ago Closed 16 years ago

Cut & paste from search results in Places Organizer are slow

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: klassphere, Unassigned)

References

Details

(Keywords: perf)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090811 Minefield/3.0a8pre ID:2007090811

1. Bookmarks | Organize Bookmarks...
2. Enter a search word in "Search in Bookmarks"
3. Select one item in the search results and right-click -> Cut
4. Remove the word from the search box, select where to put the cut item, and right-click -> Paste

3. and 4. take around 10 seconds or more while cut & paste just work fine in other occasions and takes less than a second. places.sqlite is 21,071KB.
Summary: Cut & paste from search results in Bookmarks Manager are slow → Cut & paste from search results in Places Organizer are slow
this might be a duplicate of bug #391836.

see also bug #394695
three things coming that should help:

1) mano's command updating work, see bug #394695
2) dietrich json perf work, see bug #384370
3) ignoring invalidations when possible, see bug #397117
Depends on: 384370, 394695, 397117
OS: Windows XP → All
Hardware: PC → All
> 3) ignoring invalidations when possible, see bug #397117

once it lands, we should use ignoreInvalidateContainer in wrapNode() in utils.js to ignore invalidations.
i can reproduce this given the STR in comment #1, so marking WFM. though i think this has less to do with bug 384370 than bug 399729. reporter (or anyone else), please re-open if you're still seeing this problem.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
(In reply to comment #4)
> i can reproduce this given the STR in comment #1, so marking WFM. though i
> think this has less to do with bug 384370 than bug 399729. reporter (or anyone
> else), please re-open if you're still seeing this problem.
s/can/cannot/ ?
(In reply to comment #5)
> (In reply to comment #4)
> > i can reproduce this given the STR in comment #1, so marking WFM. though i
> > think this has less to do with bug 384370 than bug 399729. reporter (or anyone
> > else), please re-open if you're still seeing this problem.
> s/can/cannot/ ?
> 

er, yeah. i *cannot* reproduce this in the latest nightly :)
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.