Provide a packages file for *nix based builds of SeaMonkey.

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
Build Config
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
seamonkey2.0a1
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 280195 [details] [diff] [review]
The fix

Providing a packages file for *nix based builds of SeaMonkey gives us some advantages - we get xpt files all linked into one or two (less file io), and for the nightly builds we only ship what we need to and not all the Test* files and support items.

The attached patch does the appropriate items. I've verified it by generating a package from my source build and then downloading a nightly and comparing directories, and hence checking that the required files are included in both (or are not required as with the case of the Test* and other files that we shouldn't be shipping).
Attachment #280195 - Flags: review?(ajschult)

Comment 1

11 years ago
Comment on attachment 280195 [details] [diff] [review]
The fix

>+bin/defaults/profile/prefs.js

Hmm, we don't seem to have this.

>+bin/components/storage-Legacy.js

hmm, pre-emptive addition for toolkit password manager?  but you're missing nsLogin*

>+; Extensions
>+;

nit: remove the extra line.

Also...
+bin/updater

I don't have this because my build seems to have updater disabled even though I didn't build with --disable-updater.  Anyway, the builds we ship now don't have updater and we don't have updates to push.  Also, firefox also has an updater.ini that we would probably need to include.
Created attachment 280377 [details] [diff] [review]
The fix v2

(In reply to comment #1)
> (From update of attachment 280195 [details] [diff] [review])
> >+bin/defaults/profile/prefs.js
> 
> Hmm, we don't seem to have this.

Dumped (ff specific)

> >+bin/components/storage-Legacy.js
> 
> hmm, pre-emptive addition for toolkit password manager?  but you're missing
> nsLogin*

I've added the nsLogin*

> Also...
> +bin/updater
> 
> I don't have this because my build seems to have updater disabled even though I
> didn't build with --disable-updater.  Anyway, the builds we ship now don't have
> updater and we don't have updates to push.  Also, firefox also has an
> updater.ini that we would probably need to include.

I've dropped this one for the time being. Whereas the login manager is simple (so I added it), this one's more complex (so I dropped it).

I've also removed the bookmarks.* stuff and updated the removed-files.in for cross-platform compatibility.
Attachment #280377 - Flags: review?(ajschult)
Comment on attachment 280195 [details] [diff] [review]
The fix

Opps forgot to obsolete the v1 patch (v2 is still valid though ;-) )
Attachment #280195 - Attachment is obsolete: true
Attachment #280195 - Flags: review?(ajschult)

Comment 4

11 years ago
Comment on attachment 280377 [details] [diff] [review]
The fix v2

> I've also removed the bookmarks.* stuff

Hmm, I guess you're anticipating landing bug 382647 first?

Index: suite/installer/windows/packages
>-bin\components\inspector.xpt

I still have one of these (and you left it in the unix part).
Attachment #280377 - Flags: review?(ajschult) → review+
(In reply to comment #4)
> (From update of attachment 280377 [details] [diff] [review])
> > I've also removed the bookmarks.* stuff
> Hmm, I guess you're anticipating landing bug 382647 first?

Yes, I'll have to kick Robert for that ;-)

> Index: suite/installer/windows/packages
> >-bin\components\inspector.xpt
> I still have one of these (and you left it in the unix part).

Opps, I didn't mean to include the windows packaging changes in this patch. I think you'll find inspector.xpt is old anyway, if not it'd be nice to know what's generating it, as I don't have it.

Comment 6

11 years ago
ls -l components/inspector.xpt 
lrwxrwxrwx 1 andrew users 56 2007-08-22 00:38 components/inspector.xpt -> ../../../layout/inspector/public/_xpidlgen/inspector.xpt

Comment 7

11 years ago
Yes, inspector.xpt still seems to be build and is not a part of the DOMI extension at all, but a part of core Gecko (layout)
(In reply to comment #7)
> Yes, inspector.xpt still seems to be build and is not a part of the DOMI
> extension at all, but a part of core Gecko (layout)

Yeah, don't know how I got confused about it, I'll put it back in before I land the patch.
Patch checked in -> fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.