If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove dummyWindow

RESOLVED FIXED in Firefox 3 beta1

Status

()

Firefox
Shell Integration
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: rflint, Assigned: rflint)

Tracking

Trunk
Firefox 3 beta1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 280214 [details] [diff] [review]
Patch

Silly hack from 2001, quietly moved to browser/ by ben in '04, hasn't been used since '05.
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/components/shell/src/nsSetDefaultBrowser.js&rev=HEAD&mark=1.5
http://lxr.mozilla.org/seamonkey/search?string=dummyWindow
Attachment #280214 - Flags: review?(gavin.sharp)
Comment on attachment 280214 [details] [diff] [review]
Patch

cvs rm the file as well?
Attachment #280214 - Flags: review?(gavin.sharp) → review+
(In reply to comment #1)
> (From update of attachment 280214 [details] [diff] [review])
> cvs rm the file as well?
> 

My working tree is anonymous and MozillaBuild doesn't package cvsdo, but I'll be sure to do it on checkin :)
Target Milestone: --- → Firefox 3 M9
All my trees are anonymous, I use "cvs -d :ext:gavin%%gavinsharp.com@cvs.mozilla.org:/cvsroot" :)
Attachment #280214 - Flags: approval1.9?

Updated

10 years ago
Attachment #280214 - Flags: approval1.9? → approval1.9+
mozilla/browser/components/shell/jar.mn 1.5
mozilla/browser/components/shell/content/dummyWindow.xul delete
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 5

10 years ago
Any chance this fixes bug 395255?  Sorry if it is way off base but I can't always reproduce that crash so I wouldn't really be able to tell if this fixed it or not.  Sorry if they are not even remotely related!
(In reply to comment #5)
> Any chance this fixes bug 395255?  Sorry if it is way off base but I can't
> always reproduce that crash so I wouldn't really be able to tell if this fixed
> it or not.  Sorry if they are not even remotely related!
> 
Nope, the only thing in common is a similar name :)
You need to log in before you can comment on or make changes to this bug.